Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add net tests #779

Merged
merged 4 commits into from
May 25, 2019
Merged

Add net tests #779

merged 4 commits into from
May 25, 2019

Conversation

braydonf
Copy link
Contributor

@braydonf braydonf commented May 21, 2019 •
edited
Loading

Starts tests for the net module, and will be expanded with additional PRs.

cc: @tuxcanfly and @pinheadmz

@codecov-io

This comment has been minimized.

Sign in to view
@braydonf braydonf marked this pull request as ready for review May 23, 2019 21:33
@braydonf braydonf added ready for review Ready to be reviewed net labels May 23, 2019
pinheadmz
pinheadmz reviewed May 24, 2019
View reviewed changes
test/net-test.js Outdated Show resolved Hide resolved
pinheadmz
pinheadmz reviewed May 24, 2019
View reviewed changes
test/net-test.js Outdated Show resolved Hide resolved
@pinheadmz
Copy link
Member

Wow great work dude! Simple, easy to follow, clever stuff shimming in assertion tests for peer.send(), I was wondering how to test peer's responses to incoming packets without another peer to receive! Great coverage too - massive improvements to the net module.

@braydonf
Copy link
Contributor Author

Okay, great :) I've updated in the respective commits. Will land this shortly.

@braydonf
Copy link
Contributor Author

Rebased on master at 55979c1

@braydonf braydonf merged commit fbe64cf into bcoin-org:master May 25, 2019
braydonf added a commit that referenced this pull request May 25, 2019
@braydonf
Merge pull request #779 from braydonf/net-tests
a35516d 
Add net tests
@braydonf braydonf removed the ready for review Ready to be reviewed label May 25, 2019
@braydonf braydonf deleted the net-tests branch May 25, 2019 01:24
@pinheadmz pinheadmz mentioned this pull request Jun 7, 2019
Merged
@nodech nodech mentioned this pull request Sep 21, 2019
Closed
@braydonf braydonf added this to the 2.0.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinheadmz pinheadmz pinheadmz left review comments

Assignees
No one assigned
Labels
net
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@braydonf @codecov-io @pinheadmz