-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always give stack traces for error logs #771
base: master
Are you sure you want to change the base?
Conversation
@chjj Can you publish the latest changes to The update to It is so that stack traces are logged for errors, it makes debugging production errors much easier |
I have another solution at bcoin-org/blgr#5 that doesn't need the changes made to |
This comment has been minimized.
This comment has been minimized.
Okay, I've updated, and now changes to |
@braydonf Can you update all other dependencies as well ? Current deps are not compatible with |
Can be done in another PR, addressing the logger stack trace issue with this one (which is now mostly bcoin-org/blgr#5). |
d643d7f
to
745b3d0
Compare
Until |
This update will log stack traces for errors (e.g.
this.logger.error
).