Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always give stack traces for error logs #771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

braydonf
Copy link
Contributor

@braydonf braydonf commented May 15, 2019

This update will log stack traces for errors (e.g. this.logger.error).

@tynes
Copy link
Member

tynes commented May 16, 2019

@chjj Can you publish the latest changes to blgr so that this PR can include a blgr npm version in the package.json instead of referencing a specific commit?

The update to blgr in particular is this commit:
bcoin-org/blgr@f8e21fc

It is so that stack traces are logged for errors, it makes debugging production errors much easier

@braydonf
Copy link
Contributor Author

braydonf commented May 17, 2019

I have another solution at bcoin-org/blgr#5 that doesn't need the changes made to pool.js.

@codecov-io

This comment has been minimized.

@braydonf
Copy link
Contributor Author

Okay, I've updated, and now changes to net/pool.js are not necessary.

@nodech
Copy link
Member

nodech commented May 17, 2019

@braydonf Can you update all other dependencies as well ?

Current deps are not compatible with node-12.

@braydonf
Copy link
Contributor Author

braydonf commented May 17, 2019

Can be done in another PR, addressing the logger stack trace issue with this one (which is now mostly bcoin-org/blgr#5).

@braydonf braydonf force-pushed the logging branch 2 times, most recently from d643d7f to 745b3d0 Compare May 20, 2019 23:36
@braydonf
Copy link
Contributor Author

Until blgr is released, the stacks should be available in debug.log, for anyone that finds this and needs to find the stack. Unfortunately there isn't a sha512 integrity hash for git referenced dependencies, and is without semver.

@braydonf braydonf changed the title Update blgr dependency Always give stack traces for error logs May 31, 2019
@braydonf braydonf mentioned this pull request Jun 5, 2019
6 tasks
@braydonf braydonf added ready for review Ready to be reviewed logs / errors Better feedback to user or prevent user error labels Jun 7, 2019
@braydonf braydonf added waiting for dependency Waiting for a dependency update. and removed ready for review Ready to be reviewed labels Oct 8, 2019
@braydonf braydonf added this to the v3.0.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logs / errors Better feedback to user or prevent user error waiting for dependency Waiting for a dependency update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants