Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs formatting and consistency #713

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Docs formatting and consistency #713

merged 2 commits into from
Mar 4, 2019

Conversation

braydonf
Copy link
Contributor

@braydonf braydonf commented Mar 1, 2019

No description provided.

@braydonf braydonf added docs UI isn't clear or documented guidance needed quick Can be fixed quickly, code change less than 10 lines labels Mar 1, 2019
@codecov-io

This comment has been minimized.

@pinheadmz
Copy link
Member

Wonder if it's worth adding in Configuration.md the behavior described in #645

Or at least, specify that wallet.conf is read from the network-named subfolder.

Example:

~/.bcoin/bcoin.conf:
network: regtest

Then the wallet config file MUST be at ~/.bcoin/regtest/wallet.conf, and not adjacent to bcoin.conf in the root.

@braydonf
Copy link
Contributor Author

braydonf commented Mar 1, 2019

It sounds like there may be some fixes necessary for #645 that should be looked into, there could be some clarification on that in the documentation also, we can have that be in a follow-up PR.

@braydonf braydonf merged commit 38efc1a into bcoin-org:master Mar 4, 2019
braydonf added a commit that referenced this pull request Mar 4, 2019
Docs formatting and consistency
@braydonf braydonf deleted the docs branch March 5, 2019 01:26
@braydonf braydonf added this to the 2.0.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs UI isn't clear or documented guidance needed quick Can be fixed quickly, code change less than 10 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants