txdb: Include in TXDetails value of individual transaction from viewpoint of accounts and overall wallet #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new functions and their return values to the
Details
object defined intxdb.js
and returned bywallet.getHistory()
API calls, as well as by wallet eventsconfirmed
,unconfirmed
,tx
, andconflict
.The new values are
walletValue
which returns the total change to total wallet balance affected by this transaction, andaccountValues
which is an object whose keys are account IDs and values are the total balance affected to which accounts by this transaction.The effect is that tx events and history queries can now inform the user exactly "what happened" in a transaction.
Example output is below. Notice this is a transaction that sent Bitcoin from account 0 to account 1 (as well as a few other outputs, it was randomly generated)
TODO: