pkg: add lockfile #642
Merged
pkg: add lockfile #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
braydonf
force-pushed
the
pkg-lockfile
branch
from
62df14b
to
72dd4ef
Compare
braydonf
force-pushed
the
pkg-lockfile
branch
from
72dd4ef
to
a916bfa
Compare
|
✅ Installed clean at a916bfa everything works and all test pass! Is there anything else a user can do to verify? Or |
|
You can change the hashes to something obviously wrong to verify that Next is to verify that the hash is of the code that it's expected to be. |
pinheadmz
reviewed
Nov 30, 2018
| ``` bash | ||
| $ npm install -g bcoin --production | ||
| ``` | ||
| Bcoin is meant to be installed via git for security purposes, as there are security issues when installing via npm. All tagged commits for release should be signed by @chjj's [PGP key][keybase] (`B4B1F62DBAC084E333F3A04A8962AB9DE6666BBD`). Signed copies of node.js are available from [nodejs.org][node], or from your respective OS's package repositories. |
|
Looks good. I love how small our package-lock.json is now. Going forward we should start doing tarball releases as well. I've been working simple tool which creates a non-npm tarball and generates a build file for the native dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619