WIP: implement bip174 Partially Signed Bitcoin Transaction #607
Conversation
|
Most excellent! Looking forward to seeing this merged. 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 53.2% 54.37% +1.17%
==========================================
Files 104 106 +2
Lines 27724 29042 +1318
Branches 4752 4970 +218
==========================================
+ Hits 14751 15793 +1042
- Misses 12973 13249 +276
Continue to review full report at Codecov.
|
joemphilips
force-pushed
the
bip174
branch
2 times, most recently
from
e88b442
to
3be578e
Compare
lib/hd/keyorigin.js
Outdated
| constructor(options) { | ||
| this.fingerPrint = -1; | ||
| this.path = []; | ||
| this.hardened = []; |
There was a problem hiding this comment.
It looks like this member is unused and we rely on the path uint32 values to contain the hardened status internally.
There was a problem hiding this comment.
Thanks for review. Now fixed.
I'd better test against actual HW Wallets. But so far coldcard wallet is the only one supports PSBT as I know.
I'm now waiting for it to arrive. :(
joemphilips
force-pushed
the
bip174
branch
3 times, most recently
from
812529a
to
1bc32e1
Compare
pinheadmz
added
enhancement
lib/node/rpc.js
Outdated
| } | ||
|
|
||
| async createPSBT(args, help) { | ||
| if (help || args.length < 2 || 4 < args.length) |
There was a problem hiding this comment.
looks like this should be ...|| 3 < args.length
* write tests.
* implement methods for (de)serialization.
* implement methods for update and sign.
* implement methods for psbt finalization.
* implement rpc interface.
|
still not merged? |
Correct. Wanna help? |
|
@pinheadmz psbt's still unavailable in bcoin? |
Yep. this is the unmerged PR right here -- wanna help take it over or review? |
I've been trying to implement rpc methods which imitates the new bitcoin core feature "PSBT".
Not complete yet, but like to have a general feedback for my approach.
TODO:
WalletandTXDB