networks: update regtest params

[tuxcanfly]

refs #579

[codecov-io]

Codecov Report

Merging #580 into master will decrease coverage by 0.48%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   53.31%   52.82%   -0.49%     
==========================================
  Files         104      104              
  Lines       27668    27661       -7     
  Branches     4738     4736       -2     
==========================================
- Hits        14750    14611     -139     
- Misses      12918    13050     +132

Impacted Files	Coverage Δ
lib/protocol/networks.js	100% <100%> (ø)	⬆️
lib/primitives/invitem.js	18% <0%> (-14%)	⬇️
lib/net/peer.js	3.31% <0%> (-12.25%)	⬇️
lib/net/pool.js	15.09% <0%> (-0.79%)	⬇️
lib/node/node.js	63.69% <0%> (-0.22%)	⬇️
lib/node/http.js	39.18% <0%> (+0.04%)	⬆️
lib/wallet/http.js	44.55% <0%> (+0.14%)	⬆️
lib/node/fullnode.js	55.21% <0%> (+0.27%)	⬆️
lib/coins/compress.js	56.32% <0%> (+1.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe34026...6466059. Read the comment docs.

[braydonf]

Tested connecting a bitcoind + bcoin node in a regtest network, and there is also a difference with when segwit is activated, leading to bcoin rejecting blocks with:

 Rejecting block 11295a7ec45824a606403b194b1e661b35d268d13bcc0e940a88234c8dcf8230 ([2604:4080:1112:8050:da9e:f3ff:fe1f:1c66]:15000): code=invalid reason=unexpected-witness.

I've manually activated segwit on regtest for bcoin, and blocks connected.

[bucko13]

segwit gets activated around block 400 and something on regtest. Although I think I saw discussion of that getting removed now that segwit has been activated for a while.

[braydonf]

May have already been updated, the first block had witness data from testing against Bitcoin Core v0.16 regtest.

[braydonf]

I think it would be good to get this in for testing between multiple implementations. I think identifying the issue with segwit activation is the only last remaining item?

[tuxcanfly]

@braydonf Made minimal changes which enable segwit from genesis to match bitcoind.

[tynes]

Just a poke on this open PR since it isn't ready to be merged yet.

  4253 passing (34s)
  3 failing

  1) Chain
       should activate csv:

      AssertionError [ERR_ASSERTION]: false == true
      + expected - actual

      -false
      +true
      
      at new AssertionError (internal/assert.js:268:11)
      at assert (test/util/assert.js:8:11)
      at Context.it (test/chain-test.js:418:5)

  2) HTTP
       should get a block template:
     Error: Client must support segwit.
      at NodeClient.execute (node_modules/bcurl/lib/client.js:321:13)
      at process._tickCallback (internal/process/next_tick.js:68:7)

  3) Node
       should activate csv:

      AssertionError [ERR_ASSERTION]: false == true
      + expected - actual

      -false
      +true
      
      at new AssertionError (internal/assert.js:268:11)
      at assert (test/util/assert.js:8:11)
      at Context.it (test/node-test.js:353:5)

[braydonf]

Closing as #676 includes these changes.