RPC: fix several wallet RPC calls and add RPC tests #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynes
reviewed
Jul 26, 2018
This comment has been minimized.
This comment has been minimized.
braydonf
reviewed
Jul 30, 2018
pinheadmz
force-pushed
the
rpcfixandtest
branch
from
c38a2d0
to
283a527
Compare
|
Just rebased on master to make sure the new |
pinheadmz
force-pushed
the
rpcfixandtest
branch
from
283a527
to
a03bf72
Compare
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Dec 22, 2018
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Dec 22, 2018
includes necessary fixes from bcoin-org#550
nodech
pushed a commit
to bpanel-org/bcoin
that referenced
this pull request
Jan 17, 2019
test: add utility to sleep for desired ms wallet: add test cases for wallet tx count and time indexing wallet: add db layout for tx count and monotonic time wallet: implement monotonic time wallet: add tx count index for confirmed txs wallet: add rpc methods for tx count and monotonic time test: restore count to generateBlocks regtest util docs: after is exclusive wallet: monotonic time indexing test: add reorg to wallet time test test: monotonic time reorg, incomplete pkg: update bdb package to support reverse wallet: rollback monotonic time wallet: add spv monotonic time reorg wallet: reorg tx monotonic time and count indexes wallet: refactor monotonic index method wallet: options for list history methods wallet: add indexing for unconfirmed count and time wallet: add methods to query for unconfirmed txs test: confirm and unconfirm txs wallet: combine `getPending` and `listUnconfirmed` wallet: http endpoints for history and unconfirmed txs wallet: test spv node http endpoints and w/ fixes test: remove `.skip` function call, it's not implemented in bmocha test: wallet rescan test pkg: update bdb wallet: use height + index for count index test: remove spv from wallet rescan test test: assertions for wallet rescan test wallet: use median time past for time indexing wallet: linting wallet: use brhash for http after param test: fix spv test when cpu is loaded wallet: minor cleanup wallet: cleanup indexes wallet: make configurable max transactions limits wallet: minor cleanup wallet: fix configurable txs limits test: bump wallet http before hook time wallet: fix http time tx queries wallet: minor linting wallet: check rpc min args length test: minor linting wallet: fix sorting of time indexing wallet: use brhash instead of manually reversing docs: minor linting wallet: fix sorting of confirmed time index wallet: refactor date handling for api test: refactor utils wallet: minor cleanup and adjustments wallet: minor cleanup and update wallet: update rpc methods with new history functions includes necessary fixes from bcoin-org#550 wallet: use unix epoch time in seconds for rpc history cmds test: increase lookahead for test wallet
bucko13
pushed a commit
to bpanel-org/bcoin
that referenced
this pull request
Jan 17, 2019
test: add utility for test fs cleanup test: add utility to sleep for desired ms wallet: add test cases for wallet tx count and time indexing wallet: add db layout for tx count and monotonic time wallet: implement monotonic time wallet: add tx count index for confirmed txs wallet: add rpc methods for tx count and monotonic time test: restore count to generateBlocks regtest util docs: after is exclusive wallet: monotonic time indexing test: add reorg to wallet time test test: monotonic time reorg, incomplete pkg: update bdb package to support reverse wallet: rollback monotonic time wallet: add spv monotonic time reorg wallet: reorg tx monotonic time and count indexes wallet: refactor monotonic index method wallet: options for list history methods wallet: add indexing for unconfirmed count and time wallet: add methods to query for unconfirmed txs test: confirm and unconfirm txs wallet: combine `getPending` and `listUnconfirmed` wallet: http endpoints for history and unconfirmed txs wallet: test spv node http endpoints and w/ fixes test: remove `.skip` function call, it's not implemented in bmocha test: wallet rescan test pkg: update bdb wallet: use height + index for count index test: remove spv from wallet rescan test test: assertions for wallet rescan test wallet: use median time past for time indexing wallet: linting wallet: use brhash for http after param test: fix spv test when cpu is loaded wallet: minor cleanup wallet: cleanup indexes wallet: make configurable max transactions limits wallet: minor cleanup wallet: fix configurable txs limits test: bump wallet http before hook time wallet: fix http time tx queries wallet: minor linting wallet: check rpc min args length test: minor linting wallet: fix sorting of time indexing wallet: use brhash instead of manually reversing docs: minor linting wallet: fix sorting of confirmed time index wallet: refactor date handling for api test: refactor utils wallet: minor cleanup and adjustments wallet: minor cleanup and update wallet: update rpc methods with new history functions includes necessary fixes from bcoin-org#550 wallet: use unix epoch time in seconds for rpc history cmds test: increase lookahead for test wallet
Closed
pinheadmz
added
bug fix
tests
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Jan 28, 2019
includes necessary fixes from bcoin-org#550
|
Looks like a very brief version of this PR was merged into hsd: handshake-org/hsd@06d52af Would be fine just to double-back-port that |
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 12, 2019
includes necessary fixes from bcoin-org#550
6 tasks
bucko13
pushed a commit
to bpanel-org/bcoin
that referenced
this pull request
Feb 18, 2019
test: add utility for test fs cleanup test: add utility to sleep for desired ms wallet: add test cases for wallet tx count and time indexing wallet: add db layout for tx count and monotonic time wallet: implement monotonic time wallet: add tx count index for confirmed txs wallet: add rpc methods for tx count and monotonic time test: restore count to generateBlocks regtest util docs: after is exclusive wallet: monotonic time indexing test: add reorg to wallet time test test: monotonic time reorg, incomplete pkg: update bdb package to support reverse wallet: rollback monotonic time wallet: add spv monotonic time reorg wallet: reorg tx monotonic time and count indexes wallet: refactor monotonic index method wallet: options for list history methods wallet: add indexing for unconfirmed count and time wallet: add methods to query for unconfirmed txs test: confirm and unconfirm txs wallet: combine `getPending` and `listUnconfirmed` wallet: http endpoints for history and unconfirmed txs wallet: test spv node http endpoints and w/ fixes test: remove `.skip` function call, it's not implemented in bmocha test: wallet rescan test pkg: update bdb wallet: use height + index for count index test: remove spv from wallet rescan test test: assertions for wallet rescan test wallet: use median time past for time indexing wallet: linting wallet: use brhash for http after param test: fix spv test when cpu is loaded wallet: minor cleanup wallet: cleanup indexes wallet: make configurable max transactions limits wallet: minor cleanup wallet: fix configurable txs limits test: bump wallet http before hook time wallet: fix http time tx queries wallet: minor linting wallet: check rpc min args length test: minor linting wallet: fix sorting of time indexing wallet: use brhash instead of manually reversing docs: minor linting wallet: fix sorting of confirmed time index wallet: refactor date handling for api test: refactor utils wallet: minor cleanup and adjustments wallet: minor cleanup and update wallet: update rpc methods with new history functions includes necessary fixes from bcoin-org#550 wallet: use unix epoch time in seconds for rpc history cmds test: increase lookahead for test wallet
This was referenced Feb 21, 2019
Merged
|
Considering the discussion on #705 how about we have this PR fix many of the RPC methods, and separate out the updates to the help command for later improvements that are generated. I have run into a few of these RPC issues myself, and it's been necessary to bring a few of the fixes as in #605 and as you mention also hsd. |
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Mar 2, 2019
includes necessary fixes from bcoin-org#550
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 6, 2019
braydonf
reviewed
Mar 8, 2019
braydonf
reviewed
Mar 8, 2019
braydonf
reviewed
Mar 8, 2019
braydonf
reviewed
Mar 8, 2019
braydonf
reviewed
Mar 8, 2019
braydonf
reviewed
Mar 8, 2019
pinheadmz
force-pushed
the
rpcfixandtest
branch
from
26dee7d
to
7278c98
Compare
wallet-rpc: fix listsinceblock height wdb: fix getWalletPaths() always return nothing wallet: add unlockCoins() for lockunspent rpc wallet-rpc: correct num args for some rpc calls wallet-rpc: fix args for importwallet and importprunedfunds wallet-rpc: importprunedfunds error misleading wallet-rpc: importPubkey args wallet-rpc: listsinceblock arg count error wallet-rpc: listTransactions ignoring account param wallet-rpc: better sendMany error msgs wallet-rpc: sendMany subtractfee is bool not obj wallet-rpc: dont check if not implemented test: add rpc-test
pinheadmz
force-pushed
the
rpcfixandtest
branch
from
7278c98
to
5751b8c
Compare
braydonf
added a commit
that referenced
this pull request
Mar 11, 2019
RPC: fix several wallet RPC calls and add RPC tests
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Mar 21, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Apr 3, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
May 15, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
May 16, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
May 17, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Jun 5, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Jun 27, 2019
includes necessary fixes from bcoin-org#550
braydonf
added a commit
that referenced
this pull request
Apr 3, 2020
includes necessary fixes from #550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges: #526, #530, #531, #544, and #545.
Also added new test
rpc-test.jsthat tests all of the above affected RPC calls, and a few others mainly to support those. Further RPC tests will be added in a different PR.