Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use req.wallet for lock coin endpoints #316

Merged
merged 3 commits into from
Oct 19, 2017
Merged

Conversation

bucko13
Copy link
Contributor

@bucko13 bucko13 commented Sep 19, 2017

Fixes Issue #315

@bucko13
Copy link
Contributor Author

bucko13 commented Sep 19, 2017

found another bug when using the HTTPWallet methods where the client was passing hash and index in the body rather than as parameters as the http module expects.

@tuxcanfly
Copy link
Member

tuxcanfly commented Sep 20, 2017

Yet to investigate but I found that httpWallet.lockCoin seems to return

[error] (node) No routes found for path: /primary/coin/locked.

Noting it here as it might be related.

Edit: Looks like this has been fixed as mentioned in the second comment.

@chjj chjj merged commit 5ba79e4 into bcoin-org:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants