RPC Tests - Node #303
Closed
RPC Tests - Node #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in progress, not enough calls / methods added. I am open to suggestions, along with overall ideas as to what should be added. I initially hadn't planned on submitting these tests until I had written about 20+ calls to the lib/http/rpc.js file that calls out to the FullNode.
Also, like to note that I'd even be open to adding unit-tests for the RPC-Calls that call out to the Wallet.
Ignore the extra util/assert file added in the commit I added it's the exact same as the one found in the main repository.