peer: handle addr packet.
#3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ipv6: ipv6, | ||
| port: port, | ||
| host: ((ipv4 >> 24) & 0xff) + '.' | ||
| + ((ipv4 >> 16) & 0xff) + '.' |
There was a problem hiding this comment.
Could you move first + to the end of the previous line?
| ipv4 = utils.readU32BE(addr, 24); | ||
|
|
||
| // ipv6 - BE | ||
| ipv6 = new Buffer(addr.slice(12, 24)).toString('hex'); |
There was a problem hiding this comment.
Oh, please don't use Buffer. I'm trying to minimize number of auto-included code when using browserify.
There was a problem hiding this comment.
Alright. I'll use bn.js instead.
There was a problem hiding this comment.
you could try using utils.toHex, may be?
| @@ -6,6 +6,8 @@ var utils = bcoin.utils; | |||
| var assert = utils.assert; | |||
| var constants = bcoin.protocol.constants; | |||
|
|
|||
| var bn = require('bn.js'); | |||
There was a problem hiding this comment.
heh, forgot to remove? :)
|
Landed in e76bed3 , thank you! |
tenthirtyone
pushed a commit
to tenthirtyone/bcoin
that referenced
this pull request
Oct 16, 2017
Update Bcoin & Pull in current Mongo features to mongo branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will handle the
addrpacket and emit an event on the peer object. Ideally, this event should probably be proxied to the pool object.