Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass options on keyring creation #295

Merged
merged 1 commit into from
Oct 19, 2017
Merged

pass options on keyring creation #295

merged 1 commit into from
Oct 19, 2017

Conversation

bucko13
Copy link
Contributor

@bucko13 bucko13 commented Aug 25, 2017 •
edited
Loading

I was trying to create a multisig keyring outside of the walletdb and was losing the witness option. The options in fromOptions would get lost if the key was a buffer since it would return before the options were set.

@bucko13 bucko13 requested a review from chjj August 25, 2017 00:25
@chjj chjj merged commit a4858e2 into bcoin-org:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chjj chjj Awaiting requested review from chjj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bucko13 @chjj