Primitives tests - addresses #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chjj
reviewed
Aug 23, 2017
test/address-test.js
Outdated
| const p2pkh = Buffer.from(raw, 'hex'); | ||
| const addr = Address.fromPubkeyhash(p2pkh); | ||
| const expectedAddr = '1MirQ9bwyQcGVJPwKUgapu5ouK2E2Ey4gX'; | ||
| assert(addr, expectedAddr); |
There was a problem hiding this comment.
Should be something like assert.strictEqual(addr.toString(), expectedAddr);.
tuxcanfly
force-pushed
the
test-address
branch
from
ab32fa1
to
cb767b6
Compare
tuxcanfly
force-pushed
the
test-address
branch
from
83b8a26
to
5bfbab2
Compare
|
@tuxcanfly is this still WIP? |
|
@bucko13 need to add a couple of tests for helper methods, will add those today. |
|
Merging for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started adding tests for address. WIP.