Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tx-pool unspent output handling. fixes #26. #27

Merged
merged 1 commit into from
Jun 17, 2014
Merged

Conversation

chjj
Copy link
Member

@chjj chjj commented Jun 16, 2014

This should fix #26, but I'm not sure on the commented code. @indutny, let me know what you think about it.

@chjj
Copy link
Member Author

chjj commented Jun 17, 2014

@indutny, see https://gist.github.com/chjj/dd72fa471c956406607e for my debug work. This pull request may not be the solution, but it seems to fix things. Particularly look at where the _unspent gets deleted in the outputs loop. <-- Nevermind.

@chjj
Copy link
Member Author

chjj commented Jun 17, 2014

Also, 9442920 is relevant here. It allows ownInput to check for owned inputs without an input.out.tx property. This PR wouldn't work without that commit.

@chjj
Copy link
Member Author

chjj commented Jun 17, 2014

This fix really seems to work well after testing it with termcoin and coined.

@indutny
Copy link
Collaborator

indutny commented Jun 17, 2014

ok, LGTM

@chjj
Copy link
Member Author

chjj commented Jun 17, 2014

Merging.

chjj added a commit that referenced this pull request Jun 17, 2014
fix tx-pool unspent output handling. fixes #26.
@chjj chjj merged commit 1e6de0e into master Jun 17, 2014
@chjj
Copy link
Member Author

chjj commented Jun 18, 2014

Just a note. One wallet test failed with this PR as it was. 6a03b30 fixed this, and seems to work perfectly now.

@chjj chjj deleted the tx-pool-fix branch July 17, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tx-pool.add not properly handling unspent and orphan txs
2 participants