framer: includer user-agent in version packet. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not that important. I just thought we could rep the bcoin. |
| writeU32(p, 0, 8); | ||
| assert.equal(off, 4); | ||
| off += writeU32(p, constants.services.network, off); | ||
| assert.equal(off, 8); |
There was a problem hiding this comment.
Yeah, I added a bunch of asserts just to make sure I didn't break anything. I've been running this as my own client and it seems to work well (no assertion failures, peers respond the same way they always do, etc). I can remove all the asserts now if you want.
|
LGTM |
|
All landed, thank you! |
|
Not sure my last commit made it. It fixes the array size, so instead of |
|
And thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.