Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@indutny, thoughts on this? Maybe we could quicker switch to the
filterload
stuff by sendingrelay
in the version packet? Does it matter? Also, the startHeight...is that even applied if we're using a bloom filter? Anyway, it looks like the framer method may have been doing a writeU32 on an undefined value (luckily bitwise ops cast undefineds to zero).Also, right now when you call
peer.watch()
, bcoin will throw a nasty error. couldn't calling peer.watch() without a hash be useful just to send filterload to (potentially new) peers again?