Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version packet #16

Merged
merged 3 commits into from
May 26, 2014
Merged

Version packet #16

merged 3 commits into from
May 26, 2014

Conversation

chjj
Copy link
Member

@chjj chjj commented May 20, 2014

@indutny, thoughts on this? Maybe we could quicker switch to the filterload stuff by sending relay in the version packet? Does it matter? Also, the startHeight...is that even applied if we're using a bloom filter? Anyway, it looks like the framer method may have been doing a writeU32 on an undefined value (luckily bitwise ops cast undefineds to zero).

Also, right now when you call peer.watch(), bcoin will throw a nasty error. couldn't calling peer.watch() without a hash be useful just to send filterload to (potentially new) peers again?

@indutny
Copy link
Collaborator

indutny commented May 20, 2014

Regarding relay: it should be fine to allow setting it, but for filterload purposes it is currently set to the right value, otherwise you would seen a lot of TXs and Blocks arriving before the filterload was issued.

I don't really care sending the height, but please provide a test for it :)

And good that you improved .watch() method.

@chjj
Copy link
Member Author

chjj commented May 24, 2014

My satoshi protocol branch could give new meaning to the relay option. Maybe instead of the pool.options.satoshi: true we could use pool.options.relay: false (with the default being true).

@chjj
Copy link
Member Author

chjj commented May 24, 2014

Added a test and cleaned up some small things. Should be mergeable. If it's not I can rebase + force push.

@chjj
Copy link
Member Author

chjj commented May 24, 2014

There was a small conflict. Rebased.

@indutny
Copy link
Collaborator

indutny commented May 26, 2014

Thanks!

indutny added a commit that referenced this pull request May 26, 2014
@indutny indutny merged commit 013a85c into bcoin-org:master May 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants