Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constants: add addressVersion. useful for connecting to testnet. #15

Closed
wants to merge 1 commit into from

Conversation

chjj
Copy link
Member

@chjj chjj commented May 20, 2014

No description provided.

@indutny
Copy link
Collaborator

indutny commented May 20, 2014

I don't think that there is a point of having this, unless we fully support testnet. This should require adding a lot of new constants, or even splitting the constants module into two.

@chjj
Copy link
Member Author

chjj commented May 20, 2014

I've implemented testnet in my own module. The only thing that's a pain to change from the "outside" is this value since it's hardcoded into a function and testnet uses 111 rather than 0. It's not as much work as you might think (different seeds, different checkpoint blocks, different port, different address version - sounds like a lot, but it's not that much) But I understand if you don't want to.

@indutny
Copy link
Collaborator

indutny commented May 20, 2014

What about magic value used for framing?

@indutny
Copy link
Collaborator

indutny commented May 20, 2014

How are you changing it in a module?

@chjj
Copy link
Member Author

chjj commented May 20, 2014

What about magic value used for framing?

I forgot about that one. Fair enough, but it's only a single line:

bcoin.protocol.constants.magic = 0x0709110b;

@chjj
Copy link
Member Author

chjj commented May 20, 2014

Nevermind, it's not a big deal. I have too many PRs open as it is.

@chjj chjj closed this May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants