block: add toJSON and fromJSON to Block. #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var raw = utils.toArray(json.block, 'hex'); | ||
|
|
||
| var block = new bcoin.block(json.subtype === 'merkleblock' | ||
| ? new bcoin.protocol.parser().parseMerkleBlock(raw) |
There was a problem hiding this comment.
Please put ? and : at the end of the lines.
There was a problem hiding this comment.
Also, wouldn't it make sense to create parser on the previous line and use it in both cases?
|
Should be good to go. :) |
|
Test? ;) |
|
Added tests for the framer/new .render method too. :) |
|
Thank you, landed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a Block framer, I thought this would be nice to add, in case we ever want to (or a user wants to) store full blocks.