migrate: bump up the spvchain database version in filter indexer migration

[theanmolsharma]

Closes #1095

[codecov-commenter]

Codecov Report

Merging #1097 (a50785c) into master (36bf60e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   69.35%   69.35%   -0.01%     
==========================================
  Files         158      158              
  Lines       26586    26586              
==========================================
- Hits        18439    18438       -1     
- Misses       8147     8148       +1     

Impacted Files	Coverage Δ
lib/net/hostlist.js	50.00% <0.00%> (-0.16%)	⬇️
lib/golomb/reader.js	88.67% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[pinheadmz]

We may need to add the same check for full node chain directory as well. If you have only ever used bcoin in spv mode, there will not be a ~/.bcoin/chain directory and the script will fail.

At the same time, the migrate/latest script also needs to be more clever, because if index doesn't exist we STILL need to run that script in order to bump the chain and/or spvchain databases.

[theanmolsharma]

Done!

[pinheadmz]

At the same time, the migrate/latest script also needs to be more clever, because if index doesn't exist we STILL need to run that script in order to bump the chain and/or spvchain databases.

still needs this fix I think:

--> migrate/latest ~/.bcoin-spv-only
Opened /Users/matthewzipkin/.bcoin-spv-only/spvchain.
Already upgraded.
Migration complete.
Opened /Users/matthewzipkin/.bcoin-spv-only/wallet.
Checking version.
Updating wallets...
Updated 1 wallets.
Checking version.
Updating version to 8.
Migration complete.
--> bcoin --spv --prefix ~/.bcoin-spv-only
[info] (chain) Chain is loading.
[info] (chain) Checkpoints are enabled.
[info] (chaindb) Opening ChainDB...
Error: Database version mismatch for database: "chain". Please run a data migration before opening.
    at DB.verify (/Users/matthewzipkin/Desktop/work/bcoin/node_modules/bdb/lib/db.js:568:13)
    at async ChainDB.open (/Users/matthewzipkin/Desktop/work/bcoin/lib/blockchain/chaindb.js:65:5)
    at async Chain.open (/Users/matthewzipkin/Desktop/work/bcoin/lib/blockchain/chain.js:89:5)
    at async SPVNode.open (/Users/matthewzipkin/Desktop/work/bcoin/lib/node/spvnode.js:148:5)
    at async /Users/matthewzipkin/Desktop/work/bcoin/bin/spvnode:42:3

[pinheadmz]

Ok I think this is done, thanks!

Tested this morning with a ton of configurations against a regtest blockchain with thousands of blocks and tens of thousands of transactions.

1. full node
2. full node with all indexers
3. spv node
4. spv sharing root data directory with (1)
5. spv sharing root data directory with (2)

Each instance was synced on bcoin v2.0.0 and then duplicated (ten total tests). Tested by migrating with migrate/latest and again with migrate/indexerdb0to1. Every instance migrated successfully and restarted correctly and continued syncing.