wallet: improved date handling

bcoin-org · Dec 21, 2018 · 13b7d03 · 13b7d03
1 parent 06f2863
commit 13b7d03
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/lib/wallet/http.js b/lib/wallet/http.js
@@ -769,13 +769,12 @@ class HTTP extends Server {
       const reverse = valid.bool('reverse', false);
       const limit = valid.u32('limit', 100);
       const after = valid.brhash('after');
+      const date = valid.str('date');
       let time = valid.u32('time');
-      let date = valid.str('date');
 
       if (date && !time) {
-        date = new Date(date);
-        enforce(date.toString() !== 'Invalid Date', 'Invalid date.');
         time = util.time(date);
+        enforce(time, 'Invalid date.');
       }
 
       enforce(limit <= this.options.maxTxs,
@@ -819,13 +818,12 @@ class HTTP extends Server {
       const reverse = valid.bool('reverse');
       const limit = valid.u32('limit');
       const after = valid.brhash('after');
+      const date = valid.str('date');
       let time = valid.u32('time');
-      let date = valid.str('date');
 
       if (date && !time) {
-        date = new Date(date);
-        enforce(date.toString() !== 'Invalid Date', 'Invalid date.');
         time = util.time(date);
+        enforce(time, 'Invalid date.');
       }
 
       enforce(limit <= this.options.maxTxs,

diff --git a/lib/wallet/rpc.js b/lib/wallet/rpc.js
@@ -1248,12 +1248,10 @@ class RPC extends RPCBase {
       throw new RPCError(errs.INVALID_PARAMETER,
                          `Limit above max of ${this.maxTxs}.`);
 
-    const date = new Date(timestamp);
-    if (date.toString() === 'Invalid Date')
+    const time = util.time(timestamp);
+    if (!time)
       throw new RPCError(errs.INVALID_PARAMETER, 'Invalid timestamp.');
 
-    const time = util.time(date);
-
     const recs = await wallet.listHistoryByTime(name, {time, limit, reverse});
 
     const out = [];
@@ -1337,12 +1335,10 @@ class RPC extends RPCBase {
     if (limit > 100)
       throw new RPCError(errs.INVALID_PARAMETER, 'Limit above max of 100.');
 
-    const date = new Date(timestamp);
-    if (date.toString() === 'Invalid Date')
+    const time = util.time(timestamp);
+    if (!time)
       throw new RPCError(errs.INVALID_PARAMETER, 'Invalid timestamp.');
 
-    const time = util.time(date);
-
     const recs = await wallet.listUnconfirmedByTime(
       name, {time, limit, reverse}
     );