Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test concurrency using nonceOptions #506

Merged
merged 9 commits into from
May 30, 2024
Merged

Conversation

VGabriel45
Copy link
Collaborator

@VGabriel45 VGabriel45 commented May 30, 2024

PR-Codex overview

This PR introduces a nonceOptions object to transactions across multiple test files.

Detailed summary

  • Added nonceOptions object to transactions in bundler/write.test.ts, paymaster/write.test.ts, and modules/write.test.ts test files.
  • Updated transaction structures to include nonceOptions in the sendTransaction function calls.

The following files were skipped due to too many changes: tests/account/write.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@VGabriel45 VGabriel45 requested a review from joepegler May 30, 2024 07:28
Copy link

github-actions bot commented May 30, 2024

size-limit report 📦

Path Size
core (esm) 54.37 KB (0%)
core (cjs) 59.48 KB (0%)
account (tree-shaking) 52.34 KB (0%)
bundler (tree-shaking) 2.63 KB (0%)
paymaster (tree-shaking) 2.33 KB (0%)
modules (tree-shaking) 40.57 KB (0%)

@joepegler joepegler changed the title remove nested describe chore: remove nested describe May 30, 2024
expect(receipt.success).toBe("true")
}, 50000)
})
// test("should transfer ownership of smart account to accountTwo", async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use test.skip btw. Instead of leaving comments

@joepegler joepegler changed the title chore: remove nested describe chore: add test concurrency using nonceOptions May 30, 2024
@joepegler joepegler merged commit 97c8fcd into develop May 30, 2024
6 of 7 checks passed
@joepegler joepegler deleted the fix/test_cases_fix branch May 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants