Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process.env errors #494

Merged
merged 2 commits into from
May 16, 2024
Merged

fix: process.env errors #494

merged 2 commits into from
May 16, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented May 16, 2024

Pull Request for SDK Improvement

Fix for process.env errors reported by zeroone.


PR-Codex overview

This PR enhances logging and debugging capabilities. It introduces a function to check debug mode and refactors logging with improved stringification.

Detailed summary

  • Added isDebugging function to check debug mode
  • Refactored logging to stringify body before logging
  • Updated Logger class to use isDebugging function for debug mode detection

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

VGabriel45 and others added 2 commits May 14, 2024 15:42
* feat: gas offset param for sendTransaction and sendUserOp (#474)

* feat - gas offset param for sendTransaction

* added percentage based gas offsets

* added dummyPndOverride

* refactor gas offset percentage

* refactor names and ts doc + lint

* improved tsdoc & fixed comments

* refactor sendTransaction example tsdoc comment

* refactor sendTransaction test

---------

Co-authored-by: GabiDev <gv@popoo.io>

* feat: transfer ownership (#484)

feat: transfer ownership (#484)

* feat: transfer_ownership_v2 (#488)

* feat/transfer_ownership(in progress)

* cleanup

* fix linting

* added test for transferOwnership with session key manager module

* Fix linting

* refactor: refactor based on PR review

* improve ts doc + refactor tests

* added "moduleAddress" param to transferOwnership()

* fix module tests

* removed console.logs

* fixed lint + removed unused import

* remove unused import

* added argument type for module address

---------

Co-authored-by: GabiDev <gv@popoo.io>

* chore: release v4.3.0 (#491)

* release v4.3.0

* refactor: increase timeout for transferOwnership tests

---------

Co-authored-by: GabiDev <gv@popoo.io>

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Copy link

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size
core (esm) 53.6 KB (-0.15% 🔽)
core (cjs) 58.75 KB (+0.25% 🔺)
account (tree-shaking) 51.96 KB (+0.22% 🔺)
bundler (tree-shaking) 2.39 KB (+0.87% 🔺)
paymaster (tree-shaking) 2.33 KB (+1.67% 🔺)
modules (tree-shaking) 40.57 KB (+0.23% 🔺)

@joepegler joepegler marked this pull request as ready for review May 16, 2024 10:52
@livingrockrises livingrockrises self-requested a review May 16, 2024 11:00
@joepegler joepegler requested a review from VGabriel45 May 16, 2024 11:01
@joepegler joepegler merged commit 71b5b04 into develop May 16, 2024
10 of 11 checks passed
@joepegler joepegler deleted the fix/process_env branch May 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants