Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type: sessionSigner: SupportedSigner #397

Merged

Conversation

joepegler
Copy link
Collaborator

Summary

Currently the sessionSigner is expected to be of type SmartAccountSigner, which is unpleasant DX. This changes the type to: SupportedSigner and handles the appropriate cases where alternative signers are provided

Related Issue: # (issue number)

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • [] Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@joepegler joepegler marked this pull request as ready for review January 31, 2024 12:25
Copy link
Collaborator

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@livingrockrises livingrockrises merged commit 5b86983 into v4 Jan 31, 2024
3 checks passed
livingrockrises added a commit that referenced this pull request Feb 9, 2024
* feat: accounts update

* update other packages with viem types

* fix: account compatibility

* minor fix

* code refactor with latest releases

* fix: resolve build

* turned off bundler tests

* fix: default validation params

* fix!: make bundler and paymaster public

* feat: reduce the bundle size

* fix: lint and temp test

* fix: gasless paymaster flow

* minor fixes

* remove the default chain

* fix: lint

* fix: method comment

* fix: bundler abstraction in v4

* feat: add Logger class to v4

* Feedback by @joepegler #352

* fix: logic error

* Feat(DEVX-410): Reinclude tests

* remove unused package

* fix: constructor validation initialisation

* fix: build issue

* Resolved DEVX-405

* Added e2e test for multiChain module

* Updated the "addSigner" method

* Fixed lint

* Resolved DEVX-402

Added esbuild

* Remove unused file

* Added negative tests

* Added multichainValidation tests

* Fix import

* Multichain testing support

* Added session validation module tests

* fix issues with address and update gitignore

* linkAll improvement

* watch package builds

cont

* WIP Session module

* Added tests for multi-chain validation and session validation

* unit tests fix

* Remove duplicate test

* revert tsconfig change

* Added check for paymaster in BiconomySmartAccountV2 class

* Fixed session file storage path and gitignore

* Fixed e2e nft mint test

* Added wait for tx before checking balance in test

* Resolved SMA-526

* test workflow

* test again

* fix command

* fix again

* test again

* cont.

* Added SPONSORED and ERC20 paymaster check logic in SDK + tests

* Feat(DEVX-425): Support ethers (#370)

Resolved DEVX-425: Support ethers

* Fixed lint

* Merged with v4

* Changed parameter name

* Uncomment PaymasterMode

* Added fix for selected quote case ERC20 paymaster

* Changed send user op approach in ERC20 paymaster test

* Modify sendUserOp function description

* Added throw instead of return user op

* continued

* Fix branch for deployment of docs

* Removed try catch

* Added utility func to get balance in tests

* Removed unused value param from tx obj

* Apply Signer Abstraction to modules (#375)

* Added Signer Abstraction

* fix:circular_dependency

* Resolved SM-547

* lint:fix

* Removed lint-staged (#382)

Co-authored-by: GabiDev <gv@popoo.io>

* README tweaks (#377)

* Update README.md

* createSmartAccountClient (#385)

* Add paymasterAndData validation in e2e tests (#381)

* Add paymasterAndData validation in e2e tests

* Use config values instead of hardcoded in tests

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Use RpcUrl from provider  (#379)

* Resolved SMA-549

lint:fix

log

* continued

* continued

* continued

* Remove e2e test from unit test

commit lockfile

* rpc test

* fix tests

* Feat/sma 540 check paymaster userop (#384)

* Refactor paymasterServiceData validation logic for ERC20 mode

* Add assertions and test case for ERC20 Paymaster user op

* Changed isNullOrUndefined function param to any type

* Update createSmartWalletClient to createSmartAccountClient

* Added ts-doc for setPaymasterUserOp

* Export FeeQuotesOrDataResponse from @account and update import path in test

* Refactor setPaymasterUserOp --> getPaymasterUserOp

---------

Co-authored-by: GabiDev <gv@popoo.io>

* update lockfile

* Add ethersV6 compatibility (#387)

* Fix for etherv6 signer compatibility

* Refactor name

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-559): Improved dx for erc20 paymaster calls (#388)

* Resolved SMA-559

* Fix await

* Fix tests

* Update docs

* remove unused import

* Fix broken tests

* Fix rpc url

* buildTokenPaymasterUserOp

* lint:fix

* Fix spender

* Abstract tokenlist away

* fix test

* fix await

* lint:fix

* Make getPaymasterUserOp public

* remove log

* Except sessionStorageData folder from gitignore but not files (#389)

Co-authored-by: GabiDev <gv@popoo.io>

* fixes in v4 for front end frameworks (#392)

* fixes in v4 for front end frameworks

* revert build scripts

* Added simulationType flag (#390)

* Added simulationType flag

* Change params for sendTransaction

* Modified sendTransaction params for simulationType + moduleInfo params

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Fix(SMA-574): ESM builds (#393)

* es build fixes

Resolved SMA-574

* Include both builds

* Default build with tsc

* minify_tsc_build

* Fix check for maxApproval in BiconomySmartAccountV2 (#395)

Co-authored-by: GabiDev <gv@popoo.io>

* Bugfix/api error message (#396)

* Fix check for maxApproval in BiconomySmartAccountV2

* Fixed api error response + increment time for test

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Change type: sessionSigner: SupportedSigner (#397)

* Fixed merkletreejs import (#400)

* Fixed merkletreejs import

* Removed console log

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-579): Allow empty tokenInfo fields during getTokenFees (#399)

* Resolved SMA-579

* added e2e tests

* lint:fix & update docs

* fix: token paymaster approval flows

* continued

* test fix

* Remove max approval from tests

---------

Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* yarn lock

* Feat(SMA-583): Update README.md with v4 examples (#405)

* continued docs + readme updates

* Updated README.md

* lint:fix

* update lockfile

* Added string as a supported Transaction value type (#404)

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added export for UserOpStatus type from /account (#403)

* Exported UserOpStatus type from /account

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added needed exports from modules (#402)

* Added needed exports from modules

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added readme (#409)

Co-authored-by: GabiDev <gv@popoo.io>

* Commented overrides and skipBundlerGasEstimation params (#407)

Co-authored-by: GabiDev <gv@popoo.io>

* V4 with viem v2 (bump aa-core and viem) (#406)

* update aa-core and viem packages

* update rest of the code to use updated deps

* update lockfile

* fix: build error

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>

* update lockfile

* Added a new param to sendRequest "service" (#412)

Co-authored-by: GabiDev <gv@popoo.io>

* Added changelog (#410)

* Make package exports consistent (#411)

* Make package exports consistent

* Update README.md s

* type comment fix

* Move default to end of exports

* LightSigner

* export LightSigner

* export type

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>
livingrockrises added a commit that referenced this pull request Feb 12, 2024
* Fix UserOpResponse wait confirmations

* birth of V4 SDK (#401)

* feat: accounts update

* update other packages with viem types

* fix: account compatibility

* minor fix

* code refactor with latest releases

* fix: resolve build

* turned off bundler tests

* fix: default validation params

* fix!: make bundler and paymaster public

* feat: reduce the bundle size

* fix: lint and temp test

* fix: gasless paymaster flow

* minor fixes

* remove the default chain

* fix: lint

* fix: method comment

* fix: bundler abstraction in v4

* feat: add Logger class to v4

* Feedback by @joepegler #352

* fix: logic error

* Feat(DEVX-410): Reinclude tests

* remove unused package

* fix: constructor validation initialisation

* fix: build issue

* Resolved DEVX-405

* Added e2e test for multiChain module

* Updated the "addSigner" method

* Fixed lint

* Resolved DEVX-402

Added esbuild

* Remove unused file

* Added negative tests

* Added multichainValidation tests

* Fix import

* Multichain testing support

* Added session validation module tests

* fix issues with address and update gitignore

* linkAll improvement

* watch package builds

cont

* WIP Session module

* Added tests for multi-chain validation and session validation

* unit tests fix

* Remove duplicate test

* revert tsconfig change

* Added check for paymaster in BiconomySmartAccountV2 class

* Fixed session file storage path and gitignore

* Fixed e2e nft mint test

* Added wait for tx before checking balance in test

* Resolved SMA-526

* test workflow

* test again

* fix command

* fix again

* test again

* cont.

* Added SPONSORED and ERC20 paymaster check logic in SDK + tests

* Feat(DEVX-425): Support ethers (#370)

Resolved DEVX-425: Support ethers

* Fixed lint

* Merged with v4

* Changed parameter name

* Uncomment PaymasterMode

* Added fix for selected quote case ERC20 paymaster

* Changed send user op approach in ERC20 paymaster test

* Modify sendUserOp function description

* Added throw instead of return user op

* continued

* Fix branch for deployment of docs

* Removed try catch

* Added utility func to get balance in tests

* Removed unused value param from tx obj

* Apply Signer Abstraction to modules (#375)

* Added Signer Abstraction

* fix:circular_dependency

* Resolved SM-547

* lint:fix

* Removed lint-staged (#382)

Co-authored-by: GabiDev <gv@popoo.io>

* README tweaks (#377)

* Update README.md

* createSmartAccountClient (#385)

* Add paymasterAndData validation in e2e tests (#381)

* Add paymasterAndData validation in e2e tests

* Use config values instead of hardcoded in tests

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Use RpcUrl from provider  (#379)

* Resolved SMA-549

lint:fix

log

* continued

* continued

* continued

* Remove e2e test from unit test

commit lockfile

* rpc test

* fix tests

* Feat/sma 540 check paymaster userop (#384)

* Refactor paymasterServiceData validation logic for ERC20 mode

* Add assertions and test case for ERC20 Paymaster user op

* Changed isNullOrUndefined function param to any type

* Update createSmartWalletClient to createSmartAccountClient

* Added ts-doc for setPaymasterUserOp

* Export FeeQuotesOrDataResponse from @account and update import path in test

* Refactor setPaymasterUserOp --> getPaymasterUserOp

---------

Co-authored-by: GabiDev <gv@popoo.io>

* update lockfile

* Add ethersV6 compatibility (#387)

* Fix for etherv6 signer compatibility

* Refactor name

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-559): Improved dx for erc20 paymaster calls (#388)

* Resolved SMA-559

* Fix await

* Fix tests

* Update docs

* remove unused import

* Fix broken tests

* Fix rpc url

* buildTokenPaymasterUserOp

* lint:fix

* Fix spender

* Abstract tokenlist away

* fix test

* fix await

* lint:fix

* Make getPaymasterUserOp public

* remove log

* Except sessionStorageData folder from gitignore but not files (#389)

Co-authored-by: GabiDev <gv@popoo.io>

* fixes in v4 for front end frameworks (#392)

* fixes in v4 for front end frameworks

* revert build scripts

* Added simulationType flag (#390)

* Added simulationType flag

* Change params for sendTransaction

* Modified sendTransaction params for simulationType + moduleInfo params

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Fix(SMA-574): ESM builds (#393)

* es build fixes

Resolved SMA-574

* Include both builds

* Default build with tsc

* minify_tsc_build

* Fix check for maxApproval in BiconomySmartAccountV2 (#395)

Co-authored-by: GabiDev <gv@popoo.io>

* Bugfix/api error message (#396)

* Fix check for maxApproval in BiconomySmartAccountV2

* Fixed api error response + increment time for test

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Change type: sessionSigner: SupportedSigner (#397)

* Fixed merkletreejs import (#400)

* Fixed merkletreejs import

* Removed console log

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-579): Allow empty tokenInfo fields during getTokenFees (#399)

* Resolved SMA-579

* added e2e tests

* lint:fix & update docs

* fix: token paymaster approval flows

* continued

* test fix

* Remove max approval from tests

---------

Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* yarn lock

* Feat(SMA-583): Update README.md with v4 examples (#405)

* continued docs + readme updates

* Updated README.md

* lint:fix

* update lockfile

* Added string as a supported Transaction value type (#404)

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added export for UserOpStatus type from /account (#403)

* Exported UserOpStatus type from /account

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added needed exports from modules (#402)

* Added needed exports from modules

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added readme (#409)

Co-authored-by: GabiDev <gv@popoo.io>

* Commented overrides and skipBundlerGasEstimation params (#407)

Co-authored-by: GabiDev <gv@popoo.io>

* V4 with viem v2 (bump aa-core and viem) (#406)

* update aa-core and viem packages

* update rest of the code to use updated deps

* update lockfile

* fix: build error

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>

* update lockfile

* Added a new param to sendRequest "service" (#412)

Co-authored-by: GabiDev <gv@popoo.io>

* Added changelog (#410)

* Make package exports consistent (#411)

* Make package exports consistent

* Update README.md s

* type comment fix

* Move default to end of exports

* LightSigner

* export LightSigner

* export type

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>

* Release 8 - Biconomy V4 SDK (#414)

* update lockfile

* chore: release r8 update package version

* Update modules changelog

---------

Co-authored-by: Joe Pegler <joepegler123@gmail.com>

* Replaced baseGoerli with baseSepolia (#415)

Co-authored-by: GabiDev <gv@popoo.io>

* Fix for encodeAbiParameters inside batched session module (#416)

Co-authored-by: GabiDev <gv@popoo.io>

---------

Co-authored-by: Aurélien <aurelien@avicenne.studio>
Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>
livingrockrises added a commit that referenced this pull request Mar 1, 2024
* Merge Develop to Main (#417)

* Fix UserOpResponse wait confirmations

* birth of V4 SDK (#401)

* feat: accounts update

* update other packages with viem types

* fix: account compatibility

* minor fix

* code refactor with latest releases

* fix: resolve build

* turned off bundler tests

* fix: default validation params

* fix!: make bundler and paymaster public

* feat: reduce the bundle size

* fix: lint and temp test

* fix: gasless paymaster flow

* minor fixes

* remove the default chain

* fix: lint

* fix: method comment

* fix: bundler abstraction in v4

* feat: add Logger class to v4

* Feedback by @joepegler #352

* fix: logic error

* Feat(DEVX-410): Reinclude tests

* remove unused package

* fix: constructor validation initialisation

* fix: build issue

* Resolved DEVX-405

* Added e2e test for multiChain module

* Updated the "addSigner" method

* Fixed lint

* Resolved DEVX-402

Added esbuild

* Remove unused file

* Added negative tests

* Added multichainValidation tests

* Fix import

* Multichain testing support

* Added session validation module tests

* fix issues with address and update gitignore

* linkAll improvement

* watch package builds

cont

* WIP Session module

* Added tests for multi-chain validation and session validation

* unit tests fix

* Remove duplicate test

* revert tsconfig change

* Added check for paymaster in BiconomySmartAccountV2 class

* Fixed session file storage path and gitignore

* Fixed e2e nft mint test

* Added wait for tx before checking balance in test

* Resolved SMA-526

* test workflow

* test again

* fix command

* fix again

* test again

* cont.

* Added SPONSORED and ERC20 paymaster check logic in SDK + tests

* Feat(DEVX-425): Support ethers (#370)

Resolved DEVX-425: Support ethers

* Fixed lint

* Merged with v4

* Changed parameter name

* Uncomment PaymasterMode

* Added fix for selected quote case ERC20 paymaster

* Changed send user op approach in ERC20 paymaster test

* Modify sendUserOp function description

* Added throw instead of return user op

* continued

* Fix branch for deployment of docs

* Removed try catch

* Added utility func to get balance in tests

* Removed unused value param from tx obj

* Apply Signer Abstraction to modules (#375)

* Added Signer Abstraction

* fix:circular_dependency

* Resolved SM-547

* lint:fix

* Removed lint-staged (#382)

Co-authored-by: GabiDev <gv@popoo.io>

* README tweaks (#377)

* Update README.md

* createSmartAccountClient (#385)

* Add paymasterAndData validation in e2e tests (#381)

* Add paymasterAndData validation in e2e tests

* Use config values instead of hardcoded in tests

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Use RpcUrl from provider  (#379)

* Resolved SMA-549

lint:fix

log

* continued

* continued

* continued

* Remove e2e test from unit test

commit lockfile

* rpc test

* fix tests

* Feat/sma 540 check paymaster userop (#384)

* Refactor paymasterServiceData validation logic for ERC20 mode

* Add assertions and test case for ERC20 Paymaster user op

* Changed isNullOrUndefined function param to any type

* Update createSmartWalletClient to createSmartAccountClient

* Added ts-doc for setPaymasterUserOp

* Export FeeQuotesOrDataResponse from @account and update import path in test

* Refactor setPaymasterUserOp --> getPaymasterUserOp

---------

Co-authored-by: GabiDev <gv@popoo.io>

* update lockfile

* Add ethersV6 compatibility (#387)

* Fix for etherv6 signer compatibility

* Refactor name

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-559): Improved dx for erc20 paymaster calls (#388)

* Resolved SMA-559

* Fix await

* Fix tests

* Update docs

* remove unused import

* Fix broken tests

* Fix rpc url

* buildTokenPaymasterUserOp

* lint:fix

* Fix spender

* Abstract tokenlist away

* fix test

* fix await

* lint:fix

* Make getPaymasterUserOp public

* remove log

* Except sessionStorageData folder from gitignore but not files (#389)

Co-authored-by: GabiDev <gv@popoo.io>

* fixes in v4 for front end frameworks (#392)

* fixes in v4 for front end frameworks

* revert build scripts

* Added simulationType flag (#390)

* Added simulationType flag

* Change params for sendTransaction

* Modified sendTransaction params for simulationType + moduleInfo params

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Fix(SMA-574): ESM builds (#393)

* es build fixes

Resolved SMA-574

* Include both builds

* Default build with tsc

* minify_tsc_build

* Fix check for maxApproval in BiconomySmartAccountV2 (#395)

Co-authored-by: GabiDev <gv@popoo.io>

* Bugfix/api error message (#396)

* Fix check for maxApproval in BiconomySmartAccountV2

* Fixed api error response + increment time for test

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Change type: sessionSigner: SupportedSigner (#397)

* Fixed merkletreejs import (#400)

* Fixed merkletreejs import

* Removed console log

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-579): Allow empty tokenInfo fields during getTokenFees (#399)

* Resolved SMA-579

* added e2e tests

* lint:fix & update docs

* fix: token paymaster approval flows

* continued

* test fix

* Remove max approval from tests

---------

Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* yarn lock

* Feat(SMA-583): Update README.md with v4 examples (#405)

* continued docs + readme updates

* Updated README.md

* lint:fix

* update lockfile

* Added string as a supported Transaction value type (#404)

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added export for UserOpStatus type from /account (#403)

* Exported UserOpStatus type from /account

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added needed exports from modules (#402)

* Added needed exports from modules

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added readme (#409)

Co-authored-by: GabiDev <gv@popoo.io>

* Commented overrides and skipBundlerGasEstimation params (#407)

Co-authored-by: GabiDev <gv@popoo.io>

* V4 with viem v2 (bump aa-core and viem) (#406)

* update aa-core and viem packages

* update rest of the code to use updated deps

* update lockfile

* fix: build error

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>

* update lockfile

* Added a new param to sendRequest "service" (#412)

Co-authored-by: GabiDev <gv@popoo.io>

* Added changelog (#410)

* Make package exports consistent (#411)

* Make package exports consistent

* Update README.md s

* type comment fix

* Move default to end of exports

* LightSigner

* export LightSigner

* export type

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>

* Release 8 - Biconomy V4 SDK (#414)

* update lockfile

* chore: release r8 update package version

* Update modules changelog

---------

Co-authored-by: Joe Pegler <joepegler123@gmail.com>

* Replaced baseGoerli with baseSepolia (#415)

Co-authored-by: GabiDev <gv@popoo.io>

* Fix for encodeAbiParameters inside batched session module (#416)

Co-authored-by: GabiDev <gv@popoo.io>

---------

Co-authored-by: Aurélien <aurelien@avicenne.studio>
Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>

* Resolve SMA-673

* Fix(SMA-677): Particle auth build broken

* bump aa-core version

* Update changelogs

* Particle build revert

* bump version

* cont.

Skip necessary batched session validation tests

* add missing env var

* exit gracefully

* fix tests

---------

Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>
Co-authored-by: Aurélien <aurelien@avicenne.studio>
Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>
livingrockrises added a commit that referenced this pull request Mar 4, 2024
* Merge Develop to Main (#417)

* Fix UserOpResponse wait confirmations

* birth of V4 SDK (#401)

* feat: accounts update

* update other packages with viem types

* fix: account compatibility

* minor fix

* code refactor with latest releases

* fix: resolve build

* turned off bundler tests

* fix: default validation params

* fix!: make bundler and paymaster public

* feat: reduce the bundle size

* fix: lint and temp test

* fix: gasless paymaster flow

* minor fixes

* remove the default chain

* fix: lint

* fix: method comment

* fix: bundler abstraction in v4

* feat: add Logger class to v4

* Feedback by @joepegler #352

* fix: logic error

* Feat(DEVX-410): Reinclude tests

* remove unused package

* fix: constructor validation initialisation

* fix: build issue

* Resolved DEVX-405

* Added e2e test for multiChain module

* Updated the "addSigner" method

* Fixed lint

* Resolved DEVX-402

Added esbuild

* Remove unused file

* Added negative tests

* Added multichainValidation tests

* Fix import

* Multichain testing support

* Added session validation module tests

* fix issues with address and update gitignore

* linkAll improvement

* watch package builds

cont

* WIP Session module

* Added tests for multi-chain validation and session validation

* unit tests fix

* Remove duplicate test

* revert tsconfig change

* Added check for paymaster in BiconomySmartAccountV2 class

* Fixed session file storage path and gitignore

* Fixed e2e nft mint test

* Added wait for tx before checking balance in test

* Resolved SMA-526

* test workflow

* test again

* fix command

* fix again

* test again

* cont.

* Added SPONSORED and ERC20 paymaster check logic in SDK + tests

* Feat(DEVX-425): Support ethers (#370)

Resolved DEVX-425: Support ethers

* Fixed lint

* Merged with v4

* Changed parameter name

* Uncomment PaymasterMode

* Added fix for selected quote case ERC20 paymaster

* Changed send user op approach in ERC20 paymaster test

* Modify sendUserOp function description

* Added throw instead of return user op

* continued

* Fix branch for deployment of docs

* Removed try catch

* Added utility func to get balance in tests

* Removed unused value param from tx obj

* Apply Signer Abstraction to modules (#375)

* Added Signer Abstraction

* fix:circular_dependency

* Resolved SM-547

* lint:fix

* Removed lint-staged (#382)

Co-authored-by: GabiDev <gv@popoo.io>

* README tweaks (#377)

* Update README.md

* createSmartAccountClient (#385)

* Add paymasterAndData validation in e2e tests (#381)

* Add paymasterAndData validation in e2e tests

* Use config values instead of hardcoded in tests

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Use RpcUrl from provider  (#379)

* Resolved SMA-549

lint:fix

log

* continued

* continued

* continued

* Remove e2e test from unit test

commit lockfile

* rpc test

* fix tests

* Feat/sma 540 check paymaster userop (#384)

* Refactor paymasterServiceData validation logic for ERC20 mode

* Add assertions and test case for ERC20 Paymaster user op

* Changed isNullOrUndefined function param to any type

* Update createSmartWalletClient to createSmartAccountClient

* Added ts-doc for setPaymasterUserOp

* Export FeeQuotesOrDataResponse from @account and update import path in test

* Refactor setPaymasterUserOp --> getPaymasterUserOp

---------

Co-authored-by: GabiDev <gv@popoo.io>

* update lockfile

* Add ethersV6 compatibility (#387)

* Fix for etherv6 signer compatibility

* Refactor name

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-559): Improved dx for erc20 paymaster calls (#388)

* Resolved SMA-559

* Fix await

* Fix tests

* Update docs

* remove unused import

* Fix broken tests

* Fix rpc url

* buildTokenPaymasterUserOp

* lint:fix

* Fix spender

* Abstract tokenlist away

* fix test

* fix await

* lint:fix

* Make getPaymasterUserOp public

* remove log

* Except sessionStorageData folder from gitignore but not files (#389)

Co-authored-by: GabiDev <gv@popoo.io>

* fixes in v4 for front end frameworks (#392)

* fixes in v4 for front end frameworks

* revert build scripts

* Added simulationType flag (#390)

* Added simulationType flag

* Change params for sendTransaction

* Modified sendTransaction params for simulationType + moduleInfo params

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Fix(SMA-574): ESM builds (#393)

* es build fixes

Resolved SMA-574

* Include both builds

* Default build with tsc

* minify_tsc_build

* Fix check for maxApproval in BiconomySmartAccountV2 (#395)

Co-authored-by: GabiDev <gv@popoo.io>

* Bugfix/api error message (#396)

* Fix check for maxApproval in BiconomySmartAccountV2

* Fixed api error response + increment time for test

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Change type: sessionSigner: SupportedSigner (#397)

* Fixed merkletreejs import (#400)

* Fixed merkletreejs import

* Removed console log

---------

Co-authored-by: GabiDev <gv@popoo.io>

* Feat(SMA-579): Allow empty tokenInfo fields during getTokenFees (#399)

* Resolved SMA-579

* added e2e tests

* lint:fix & update docs

* fix: token paymaster approval flows

* continued

* test fix

* Remove max approval from tests

---------

Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* yarn lock

* Feat(SMA-583): Update README.md with v4 examples (#405)

* continued docs + readme updates

* Updated README.md

* lint:fix

* update lockfile

* Added string as a supported Transaction value type (#404)

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added export for UserOpStatus type from /account (#403)

* Exported UserOpStatus type from /account

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added needed exports from modules (#402)

* Added needed exports from modules

* update lockfile

---------

Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>

* Added readme (#409)

Co-authored-by: GabiDev <gv@popoo.io>

* Commented overrides and skipBundlerGasEstimation params (#407)

Co-authored-by: GabiDev <gv@popoo.io>

* V4 with viem v2 (bump aa-core and viem) (#406)

* update aa-core and viem packages

* update rest of the code to use updated deps

* update lockfile

* fix: build error

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>

* update lockfile

* Added a new param to sendRequest "service" (#412)

Co-authored-by: GabiDev <gv@popoo.io>

* Added changelog (#410)

* Make package exports consistent (#411)

* Make package exports consistent

* Update README.md s

* type comment fix

* Move default to end of exports

* LightSigner

* export LightSigner

* export type

---------

Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>

* Release 8 - Biconomy V4 SDK (#414)

* update lockfile

* chore: release r8 update package version

* Update modules changelog

---------

Co-authored-by: Joe Pegler <joepegler123@gmail.com>

* Replaced baseGoerli with baseSepolia (#415)

Co-authored-by: GabiDev <gv@popoo.io>

* Fix for encodeAbiParameters inside batched session module (#416)

Co-authored-by: GabiDev <gv@popoo.io>

---------

Co-authored-by: Aurélien <aurelien@avicenne.studio>
Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: Joe Pegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>

* Resolve SMA-673

* Fix(SMA-677): Particle auth build broken

* bump aa-core version

* Update changelogs

* Particle build revert

* bump version

---------

Co-authored-by: livingrockrises <90545960+livingrockrises@users.noreply.github.com>
Co-authored-by: Aurélien <aurelien@avicenne.studio>
Co-authored-by: amanraj1608 <archanaamanraj@gmail.com>
Co-authored-by: Aman Raj <42104907+AmanRaj1608@users.noreply.github.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Vasile Gabriel Marian <56271768+VGabriel45@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants