Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward flow bug fixes and minor optimisations #187

Merged
merged 15 commits into from
Jun 10, 2023
Merged

Conversation

livingrockrises
Copy link
Collaborator

@livingrockrises livingrockrises commented Jun 10, 2023

Description

Fixes # (issue)

scrap the code for fallback gas tank
avoid calling external api for estimating account deployment
fix handle payment override by only sending non-zero value as baseGas
rely on account computation / call to wallet factory rather than making backend api call to get smart account address
fix smart account state issue. currently sdk has to be reinitialised after doing first transaction that deploys the wallet because state doesn't get updated.
remove hard coded gas limit of 2M

required changes ref gas limits are done and deployed on the relayer side.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@talhamalik883
Copy link
Contributor

LGTM

@livingrockrises livingrockrises merged commit 7376341 into master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants