added flag to skip calldata approval patch (#441)

bcnmy · Mar 4, 2024 · 75698c8 · 75698c8
1 parent d2e8ee1
commit 75698c8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/account/src/BiconomySmartAccountV2.ts b/packages/account/src/BiconomySmartAccountV2.ts
@@ -620,6 +620,12 @@ export class BiconomySmartAccountV2 extends BaseSmartContractAccount {
         Logger.log("there is a feeQuote: ", feeQuote);
         if (!spender) throw new Error(ERROR_MESSAGES.SPENDER_REQUIRED);
         if (!feeQuote) throw new Error(ERROR_MESSAGES.FAILED_FEE_QUOTE_FETCH);
+        if (paymasterServiceData.skipPatchCallData && paymasterServiceData.skipPatchCallData === true) {
+          return this.getPaymasterAndData(userOp, {
+            ...paymasterServiceData,
+            feeTokenAddress: feeQuote.tokenAddress,
+          });
+        }
         const partialUserOp = await this.buildTokenPaymasterUserOp(userOp, {
           ...paymasterServiceData,
           spender,

diff --git a/packages/account/src/utils/Types.ts b/packages/account/src/utils/Types.ts
@@ -80,6 +80,8 @@ export type BiconomyTokenPaymasterRequest = {
   spender: Hex;
   /** maxApproval: If set to true, the paymaster will approve the maximum amount of tokens required for the transaction. Not recommended */
   maxApproval?: boolean;
+  /* skip option to patch callData if approval is already given to the paymaster */
+  skipPatchCallData?: boolean;
 };
 
 export type RequireAtLeastOne<T, Keys extends keyof T = keyof T> = Pick<T, Exclude<keyof T, Keys>> &
@@ -218,6 +220,8 @@ export type PaymasterUserOperationDto = SponsorUserOperationDto &
     spender?: Hex;
     /** Not recommended */
     maxApproval?: boolean;
+    /* skip option to patch callData if approval is already given to the paymaster */
+    skipPatchCallData?: boolean;
   };
 
 export type InitializeV2Data = {

diff --git a/packages/paymaster/src/utils/Types.ts b/packages/paymaster/src/utils/Types.ts
@@ -106,6 +106,8 @@ export type BiconomyTokenPaymasterRequest = {
   spender: Hex;
   /** Not recommended */
   maxApproval?: boolean;
+  /* skip option to patch callData if approval is already given to the paymaster */
+  skipPatchCallData?: boolean;
 };
 
 export type FeeQuotesOrDataResponse = {