fix: remove sign typed data (#548)

* fix: remove signTypedData implementation * fix: fixed build issues --------- Co-authored-by: GabiDev <gv@popoo.io>
bcnmy · Aug 8, 2024 · 41140a7 · 41140a7
1 parent 907a2dc
commit 41140a7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/src/account/BaseSmartContractAccount.ts b/src/account/BaseSmartContractAccount.ts
@@ -132,7 +132,7 @@ export abstract class BaseSmartContractAccount<
    * @param _params -- Typed Data params to sign
    */
   async signTypedData(_params: SignTypedDataParams): Promise<`0x${string}`> {
-    return this.signer.signTypedData(_params)
+    throw new Error("signTypedData not supported")
   }
 
   /**
@@ -158,14 +158,16 @@ export abstract class BaseSmartContractAccount<
    * @param params -- Typed Data params to sign
    */
   async signTypedDataWith6492(
+    // @ts-ignore
     params: SignTypedDataParams
   ): Promise<`0x${string}`> {
-    const [isDeployed, signature] = await Promise.all([
-      this.isAccountDeployed(),
-      this.signTypedData(params)
-    ])
+    throw new Error("signTypedDataWith6492 not supported")
+    // const [isDeployed, signature] = await Promise.all([
+    //   this.isAccountDeployed(),
+    //   this.signTypedData(params)
+    // ])
 
-    return this.create6492Signature(isDeployed, signature)
+    // return this.create6492Signature(isDeployed, signature)
   }
 
   /**

diff --git a/src/account/utils/Types.ts b/src/account/utils/Types.ts
@@ -558,7 +558,7 @@ export interface ISmartContractAccount<
    * @param params - {@link SignTypedDataParams}
    * @returns the signed hash for the message passed
    */
-  signTypedData(params: SignTypedDataParams): Promise<Hash>;
+  // signTypedData(params: SignTypedDataParams): Promise<Hash>;
 
   /**
    * If the account is not deployed, it will sign the message and then wrap it in 6492 format
@@ -574,7 +574,7 @@ export interface ISmartContractAccount<
    * @param params - {@link SignTypedDataParams}
    * @returns the signed hash for the params passed in wrapped in 6492 format
    */
-  signTypedDataWith6492(params: SignTypedDataParams): Promise<Hash>;
+  // signTypedDataWith6492(params: SignTypedDataParams): Promise<Hash>;
 
   /**
    * @returns the address of the account

diff --git a/tests/account/read.test.ts b/tests/account/read.test.ts
@@ -967,12 +967,7 @@ describe("Account:Read", () => {
       }
     }
 
-    const signature = await smartAccount.signTypedData(typedData)
-    const isVerified = await publicClient.verifyTypedData({
-      address: account.address,
-      signature,
-      ...typedData
-    })
-    expect(isVerified).toBeTruthy()
+    const signature = smartAccount.signTypedData(typedData)
+    expect(signature).rejects.toThrowError("signTypedData not supported")
   })
 })