Bug fix for relative directory removal #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UnitTest: https://gist.github.com/4221865 time php UnitTest-e8af5d1.php |
This fixes two bugs: - for segments that ends with ".." e.g. /user/username../details, this should not be replaced - current solution only replace double slashes, this solutions removes the infinite number of recurring slashes
|
Nice! However, in order to get this into CI, some adjustments need to be made in order to meet the styleguide requiremens. I'll comment on the diff. Edit: Also, if this fixes a bug - it should be noted in the changelog. |
|
|
||
| /** | ||
| * Remove relative directory (../) and multi slashes (///) | ||
| * @param string $url |
There was a problem hiding this comment.
Use only tabs as separators - no spaces (between 'string' and '$url' + although followed by a tab, you have spaces after both @param and @return).
Additionally, for the sake of consistency there should be an empty description line between 228 & 229.
narfbg
added a commit
that referenced
this pull request
Dec 6, 2012
Bug fix for relative directory removal
|
@narfbg I realized there's another snippet that also shares the same code |
|
That's fast! :p |
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
Bug fix for relative directory removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to fix two bugs: