Children Drivers #2036
Merged
Children Drivers #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows developers to create children drivers that are not prefix with "CI_". This is a nity grity change, however it keeps with the mindset that class names that start with CI_ are typically overrides of core classes.
| $msg = 'Unable to load the requested driver: '.$class_name; | ||
| log_message('error', $msg); | ||
| show_error($msg); | ||
| // last ditch effort. Maybe someone is coding by the 2.1 driver style. |
There was a problem hiding this comment.
Could you just remove this comment? The rest looks good. :)
|
👍 |
As requested removed useless comment
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
Children Drivers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers to create children drivers that are not prefix
with "CI_". This is a nity grity change, however it keeps with the
mindset that class names that start with CI_ are typically overrides of
core classes.