Session_cookie driver #2033
Closed
Session_cookie driver #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo in the session_cookie driver that prevented it from loading. Line 222 removed one equal sign from the if statement.
|
This is not correct pull request. |
ghost
closed this
narfbg
added a commit
that referenced
this pull request
Nov 26, 2012
Check for an empty encryption_key shouldn't use strict comparison.
|
Good thing there was a proper description. :) |
|
@narfbg can you tell me why git thinks I made 844 changes to session_cookie_driver? |
|
@williamknauss You're probably using an IDE that re-writes tabs to spaces or line endings, so it's not git that thinks so - you are in fact changing every single line, only you don't see any visual difference. |
|
Other than the tab rewrite was there anything else actually wrong with this pull request as appleboy said? |
|
Turns out the problem is with line endings and not tabs vs. spaces. Other than that I don't see a problem, but that is wrong enough. |
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
Check for an empty encryption_key shouldn't use strict comparison.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a typo in the session_cookie driver that prevented it from
loading. Line 222 removed one equal sign from the if statement.