Open
Conversation
bchavez
requested changes
Sep 26, 2025
(will add this later, after reconsidering how this should work)
Author
|
@bchavez You could check again, I have made some changes. |
bchavez
requested changes
Nov 9, 2025
| "6### ??", | ||
| "7### ??", | ||
| "8### ??", | ||
| "9### ??" |
Owner
There was a problem hiding this comment.
we shouldn't be modifying the underlying data set directly; any changes here will get clobbered over; if you need to update a dataset you need to have this JSON node replaced by data_extend/nl file; data_extend gets merged with faker.js; so ultimately any changes here will get clobbered over by an update process from faker.js.
this /data/nl.locale.json file is the ultimate output of the merge process between Bogus data_extend and faker.js import.
you can learn more about how faker.js data is imported into Bogus here:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.