feat(create): use default constructor for C# records#609
Open
riezebosch wants to merge 2 commits intobchavez:masterfrom
Open
feat(create): use default constructor for C# records#609riezebosch wants to merge 2 commits intobchavez:masterfrom
riezebosch wants to merge 2 commits intobchavez:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done some work on instantiating c# records with reflection for some other project so I thought it could come in handy. /fix #334
Did not pay too much attention on coding guidelines or where it would fit and if it should be a separate repository, but consider this a proof-of-work and any feedback on improvements appreciated.
Update: replaced the
Activator.CreateInstancewith invoking the default constructor with null for all arguments since Bogus is already updating backing fields 🤷🏻 I like myrecordsto be immutable and never contain null values, but can imagine this works best with current implementation of Bogus. Did like the fact that with this little change everything seems to just work.