Skip to content

StrictMode(true) Fixing null reference exception #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bchavez merged 2 commits into from
Dec 12, 2020
Merged

StrictMode(true) Fixing null reference exception #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b2342c
Fixing null reference exception
Basyras Nov 24, 2020
c05a8bd
Update unit test and use C# 9 feature for null checking.
bchavez Dec 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Source/Bogus.Tests/StrictModeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,22 @@ public void cannot_use_rules_with_strictmode_inside_rulesets()
Action act2 = () => faker2.AssertConfigurationIsValid();
act2.Should().Throw<ValidationException>();
}

[Fact]
public void strictmode_with_no_rules_should_throw()
{
var faker = new Faker<Examples.Order>()
.StrictMode(true);

Action act = () => faker.Generate(1);

act.Should().ThrowExactly<ValidationException>()
.WithMessage("*Missing Rules*")
.WithMessage("*Validation was called to ensure all properties*")
.WithMessage($"*{nameof(Examples.Order.OrderId)}*")
.WithMessage($"*{nameof(Examples.Order.Item)}*")
.WithMessage($"*{nameof(Examples.Order.Quantity)}*")
.WithMessage($"*{nameof(Examples.Order.LotNumber)}*");
}
}
}
2 changes: 1 addition & 1 deletion Source/Bogus/Faker[T].cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ private ValidationResult ValidateInternal(string[] ruleSets)
{
foreach( var propOrFieldOfT in userSet )
{
if( populateActions.TryGetValue(propOrFieldOfT, out var populateAction) )
if( populateActions is not null && populateActions.TryGetValue(propOrFieldOfT, out var populateAction) )
{
// Very much a .Rules() action
if( populateAction.ProhibitInStrictMode )
Expand Down