Skip to content

Comments

Refresh login only when needed#50

Merged
mathieulemieux merged 3 commits intodevelopfrom
bugfix/KBDEV-1266-slow-matching-login
Apr 2, 2025
Merged

Refresh login only when needed#50
mathieulemieux merged 3 commits intodevelopfrom
bugfix/KBDEV-1266-slow-matching-login

Conversation

@mathieulemieux
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.76%. Comparing base (8f8f656) to head (8f12dac).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
pori_python/graphkb/util.py 40.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #50      +/-   ##
===========================================
- Coverage    86.07%   85.76%   -0.32%     
===========================================
  Files           18       18              
  Lines         2398     2416      +18     
===========================================
+ Hits          2064     2072       +8     
- Misses         334      344      +10     
Flag Coverage Δ
unittests 85.76% <40.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathieulemieux mathieulemieux self-assigned this Mar 13, 2025
@mathieulemieux mathieulemieux marked this pull request as ready for review March 13, 2025 16:59
@mathieulemieux
Copy link
Member Author

Looking at ways to spped up report creation, I saw that the logging is triggered at every gkb api request.

@mathieulemieux mathieulemieux merged commit 616a308 into develop Apr 2, 2025
12 of 17 checks passed
@mathieulemieux mathieulemieux mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants