Skip to content

Added data binding to width attribute in Header component. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

Added data binding to width attribute in Header component. #29

merged 1 commit into from
Sep 10, 2020

Conversation

harrymaynard-maximus
Copy link
Contributor

@harrymaynard-maximus harrymaynard-maximus commented Sep 10, 2020 •
edited
Loading

Description

This PR includes the following proposed change(s):

Added data binding to width attribute in Header component

Screenshots

N/A

Type of change

  • [ Y ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation

How Has This Been Tested?

Manual tests in private project app.

Checklist:

  • [ Y ] My code follows the style guidelines of this project
  • [ Y ] I have performed a self-review of my own code
  • [ N ] I have made corresponding changes to the documentation
  • [ N/A ] New and existing unit tests pass locally with my changes

sdevalapurkar-bcgov
sdevalapurkar-bcgov approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@sdevalapurkar-bcgov sdevalapurkar-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

sdevalapurkar-bcgov
sdevalapurkar-bcgov approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@sdevalapurkar-bcgov sdevalapurkar-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sdevalapurkar-bcgov sdevalapurkar-bcgov merged commit 67c449e into master Sep 10, 2020
@sdevalapurkar-bcgov sdevalapurkar-bcgov deleted the header-width-fix branch September 10, 2020 22:22
@sdevalapurkar-bcgov sdevalapurkar-bcgov mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdevalapurkar-bcgov sdevalapurkar-bcgov sdevalapurkar-bcgov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrymaynard-maximus @sdevalapurkar-bcgov