Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how MAC OS options are applied. #288

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

WadeBarnes
Copy link
Member

Refactors and simplifies (centralizes) how Linux/MAC command line options are applied to the scripts.

resolves #271

Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes WadeBarnes requested review from swcurran and esune January 8, 2024 22:29
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — not sure I tested the right paths but did run fine on my Mac.

@WadeBarnes
Copy link
Member Author

LGTM — not sure I tested the right paths but did run fine on my Mac.

Thanks. I ran tests on my MAC and PC.

@WadeBarnes WadeBarnes merged commit b041b9a into bcgov:main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The MacOS "stat" command is different than the GNU equivalent
2 participants