Skip to content

chore: eliminate cross-directory imports in ESLint configs #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+114 −112
Draft

chore: eliminate cross-directory imports in ESLint configs #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c64b32
Initial plan
Copilot Nov 22, 2025
67918d7
Initial plan for fixing link deprecation
Copilot Nov 22, 2025
6be4cac
Inline shared eslint config to remove cross-directory dependencies
Copilot Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion backend/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,45 @@ import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';
import prettier from 'eslint-plugin-prettier';
import prettierConfig from 'eslint-config-prettier';
import { baseRules, baseIgnores } from '../eslint-base.config.mjs';

/**
* Shared ignore patterns (inlined from eslint-base.config.mjs)
*/
const baseIgnores = [
// Build tool configs (vite, vitest, playwright, tsconfig)
'**/vite.config.*',
'**/vitest.config.*',
'**/playwright.config.*',
'**/tsconfig*.json',
// Dist, dependencies, and coverage
'**/dist/**',
'**/node_modules/**',
'**/coverage/**',
];

/**
* Shared ESLint rules (inlined from eslint-base.config.mjs)
* Note: consistent-type-imports is NOT included here because NestJS DI requires runtime class references
*/
const baseRules = {
// Prettier integration
'prettier/prettier': 'error',

// General ESLint rules
'no-console': 'off',
'no-debugger': 'warn',
'no-unused-vars': 'off',
'no-empty': ['error', { allowEmptyCatch: true }],

// TypeScript rules (shared across frontend and backend)
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-empty-interface': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',
};

export default tseslint.config(
eslint.configs.recommended,
Expand Down
34 changes: 7 additions & 27 deletions backend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 38 additions & 1 deletion frontend/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,44 @@ import react from 'eslint-plugin-react';
import reactHooks from 'eslint-plugin-react-hooks';
import prettier from 'eslint-plugin-prettier';
import prettierConfig from 'eslint-config-prettier';
import { baseRules, baseIgnores } from '../eslint-base.config.mjs';

/**
* Shared ignore patterns (inlined from eslint-base.config.mjs)
*/
const baseIgnores = [
// Build tool configs (vite, vitest, playwright, tsconfig)
'**/vite.config.*',
'**/vitest.config.*',
'**/playwright.config.*',
'**/tsconfig*.json',
// Dist, dependencies, and coverage
'**/dist/**',
'**/node_modules/**',
'**/coverage/**',
];

/**
* Shared ESLint rules (inlined from eslint-base.config.mjs)
*/
const baseRules = {
// Prettier integration
'prettier/prettier': 'error',

// General ESLint rules
'no-console': 'off',
'no-debugger': 'warn',
'no-unused-vars': 'off',
'no-empty': ['error', { allowEmptyCatch: true }],

// TypeScript rules (shared across frontend and backend)
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-empty-interface': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',
};

export default tseslint.config(
eslint.configs.recommended,
Expand Down
Loading