Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactored notifications to correctly display pr and diff on but… #1750

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

cberg-aot
Copy link
Collaborator

@cberg-aot cberg-aot commented Jan 9, 2024

…tons

Description

Refactored Notifications to alert less frequently (only on workflow completed), and to properly link the the PR/DIFF on merge notifications.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • onroutebc

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@cberg-aot
Copy link
Collaborator Author

image

merge will now correctly notify with pr#...

There is a case where a pull request may come in without a PR number, not sure how that is possible as its an attribute of the pr event. More iterations needed.

Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. :)

@cberg-aot cberg-aot added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 95b407e Jan 10, 2024
15 checks passed
@cberg-aot cberg-aot deleted the fix/notification_refactor branch January 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants