Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete Helm PR releases older than a week #1496

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Oct 18, 2023


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@DerekRoberts DerekRoberts self-assigned this Oct 18, 2023
@DerekRoberts DerekRoberts added the enhancement New feature or request label Oct 18, 2023
@DerekRoberts
Copy link
Member Author

DerekRoberts commented Oct 25, 2023

Helm has a TTL (time to live)! Investigate. Closing this PR.
https://github.com/JovianX/helm-release-plugin

UPDATE: Plugin, fails without kubectl. :'(

@DerekRoberts DerekRoberts reopened this Oct 26, 2023
@DerekRoberts DerekRoberts force-pushed the feat/helmAgeOut branch 2 times, most recently from 9f13d6c to d020adb Compare October 26, 2023 02:06
@DerekRoberts DerekRoberts marked this pull request as ready for review October 26, 2023 06:49
@DerekRoberts DerekRoberts changed the title feat: Helm support for oc cleanup feat: delete Helm PR releases older than a week Oct 26, 2023
@mishraomp
Copy link
Collaborator

mishraomp commented Oct 26, 2023

@DerekRoberts are we on HELM 2(https://v2.helm.sh/docs/helm/#helm-delete), since delete is now uninstall in HELM3 https://helm.sh/docs/helm/helm_delete/

@DerekRoberts
Copy link
Member Author

Thanks! Fixing. :)

@DerekRoberts DerekRoberts enabled auto-merge (squash) October 26, 2023 19:00
@DerekRoberts DerekRoberts linked an issue Oct 26, 2023 that may be closed by this pull request
@DerekRoberts DerekRoberts merged commit 04e64e8 into main Oct 26, 2023
13 checks passed
@DerekRoberts DerekRoberts deleted the feat/helmAgeOut branch October 26, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: add helm to PR env age out schedule
2 participants