Skip to content

fix: get PR only when the tag is not provided. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2024
Merged

fix: get PR only when the tag is not provided. #92

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2267aa4
fix: get PR only when the tag is not provided.
mishraomp Oct 14, 2024
b4289a5
add tag as fallback when it is provided
mishraomp Oct 14, 2024
e9b1ff7
add tag as fallback for helm package when no PR
mishraomp Oct 14, 2024
1b2e6fe
try with test tag
mishraomp Oct 14, 2024
ecf88d4
add a version to vars to handle workflow_dispatch prod
mishraomp Oct 14, 2024
1a42896
revert back pr-open, test is successful
mishraomp Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/.deployer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
triggers: ${{ inputs.triggers }}

# Variables
- if: steps.triggers.outputs.triggered == 'true'
- if: ${{ steps.triggers.outputs.triggered == 'true' && inputs.tag == '' }}
id: pr
uses: bcgov-nr/action-get-pr@v0.0.1
- if: steps.triggers.outputs.triggered == 'true'
Expand All @@ -94,15 +94,20 @@ jobs:
tag=${{ inputs.tag || steps.pr.outputs.pr }}

# Release name includes run numbers to ensure uniqueness
release=${{ github.event.repository.name }}-${{ inputs.environment || steps.pr.outputs.pr }}

# Summary
release=${{ github.event.repository.name }}-${{ inputs.environment || steps.pr.outputs.pr || inputs.tag }}

# version, to support helm packaging for non-pr based releases (workflow_dispatch). default to 1.0.0+github run number
version=1.0.0+${{ github.run_number }}

# Summary
echo "tag=${tag}"
echo "release=${release}"
echo "version=${version}"

# Output
echo "tag=${tag}" >> $GITHUB_OUTPUT
echo "release=${release}" >> $GITHUB_OUTPUT
echo "version=${version}" >> $GITHUB_OUTPUT

### Deploy
- name: Install CLI tools from OpenShift Mirror
Expand Down Expand Up @@ -141,7 +146,7 @@ jobs:
run: |
# Helm package
sed -i 's/^name:.*/name: ${{ github.event.repository.name }}/' Chart.yaml
helm package -u . --app-version="tag-${{ steps.vars.outputs.tag }}_run-${{ github.run_number }}" --version=${{ steps.pr.outputs.pr }}
helm package -u . --app-version="tag-${{ steps.vars.outputs.tag }}_run-${{ github.run_number }}" --version=${{ steps.pr.outputs.pr || steps.vars.outputs.version }}

# Deploy Helm chart as atomic, with timeout
- if: steps.triggers.outputs.triggered == 'true' && inputs.atomic != 'false'
Expand All @@ -155,7 +160,7 @@ jobs:
--install --wait --atomic ${{ steps.vars.outputs.release }} \
--timeout ${{ inputs.timeout-minutes }}m \
--values ${{ inputs.values }} \
./${{ github.event.repository.name }}-${{ steps.pr.outputs.pr }}.tgz
./${{ github.event.repository.name }}-${{ steps.pr.outputs.pr || steps.vars.outputs.version }}.tgz

# Deploy Helm chart without atomic or timeout
- if: steps.triggers.outputs.triggered == 'true' && inputs.atomic == 'false'
Expand All @@ -168,7 +173,7 @@ jobs:
${{ inputs.params }} \
${{ steps.vars.outputs.release }} \
--install --wait --values ${{ inputs.values }} \
./${{ github.event.repository.name }}-${{ steps.pr.outputs.pr }}.tgz
./${{ github.event.repository.name }}-${{ steps.pr.outputs.pr || steps.vars.outputs.version }}.tgz

# Helm release history
- if: steps.triggers.outputs.triggered == 'true'
Expand Down
Loading