Skip to content

Conversation

@DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Jul 2, 2025

Defaults aren't allowed in secrets, so this PR provides a fallback value for oc_namespace anyway.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings July 2, 2025 18:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the disallowed default on the oc_server input, introduces a workflow-level environment variable for the default server URL, and updates each job step to fall back to that default when the secret is not provided.

  • Remove default from oc_server input to comply with secret usage rules
  • Add DEFAULT_OC_SERVER env var at the top level
  • Update each oc_server argument to use ${{ secrets.oc_server || env.DEFAULT_OC_SERVER }}
Comments suppressed due to low confidence (2)

.github/workflows/.pr-close.yml:63

  • Consider updating the oc_server input description to mention that if no value is provided in secrets.oc_server, it will fall back to DEFAULT_OC_SERVER from the env section.
      oc_server:

.github/workflows/.pr-close.yml:126

  • [nitpick] This expression is duplicated across multiple steps; consider extracting it into a reusable job-level or workflow-level variable (e.g., via defaults or a YAML anchor) to reduce duplication and simplify future updates.
          oc_server: ${{ secrets.oc_server || env.DEFAULT_OC_SERVER }}

@DerekRoberts DerekRoberts reopened this Jul 2, 2025
@DerekRoberts DerekRoberts self-assigned this Jul 2, 2025
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Jul 2, 2025
@github-project-automation github-project-automation bot moved this from Active to Waiting in DevOps (NR) Jul 2, 2025
@DerekRoberts DerekRoberts merged commit 3116748 into main Jul 2, 2025
14 checks passed
@DerekRoberts DerekRoberts deleted the fix/secretDefault branch July 2, 2025 18:36
@github-project-automation github-project-automation bot moved this from Waiting to Done in DevOps (NR) Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants