docs: breaking change for oc_input in .pr-close.yml #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README to document a breaking change for the .pr-close.yml workflow, moving oc_server from a with input to a secret.
- Updated repository title casing
- Added “Breaking Changes” section
- Revised example to show
oc_serverinsecretsinstead ofwith
Comments suppressed due to low confidence (2)
README.md:26
- The commented-out
oc_serverentry in thewith:block may confuse users. Remove it entirely or clearly indicate that it’s deprecated.
oc_server: ${{ secrets.OC_SERVER }} # REMOVED - OPTIONAL!
README.md:9
- Clarify what happens when
oc_serveris omitted (e.g., default behavior or fallback) so users understand the impact.
`oc_server` has been moved to a secret. It is an optional field, only affecting some users.
mishraomp
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: