chore(ci): workflow permissions #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates various CI workflow files to explicitly declare GitHub Actions permissions for enhanced security and clarity.
- Explicitly sets top‑level empty permissions blocks and job-specific permissions (e.g., pull-requests: write, packages: write, contents: write)
- Applies these changes consistently across multiple workflow files (pr-open.yml, pr-close.yml, merge.yml, csr-generator.yml, .schema-spy.yml, .pr-validate.yml, and .pr-close.yml)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-open.yml | Added top‑level empty permissions and per‑job permissions for validate and builds |
| .github/workflows/pr-close.yml | Added top‑level empty permissions and per‑job permissions for cleanup |
| .github/workflows/merge.yml | Introduced job-level permissions for package writes |
| .github/workflows/csr-generator.yml | Added top‑level empty permissions to the workflow |
| .github/workflows/.schema-spy.yml | Added top‑level empty permissions and job-level permissions for documentation generation |
| .github/workflows/.pr-validate.yml | Added top‑level empty permissions and updated job-level permissions for checks |
| .github/workflows/.pr-close.yml | Added top‑level empty permissions |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines CI workflow configurations by introducing explicit permissions for various jobs to enhance security and maintainability.
- Updated workflow files (pr-open.yml, pr-close.yml, merge.yml, csr-generator.yml, .pr-validate.yml, .pr-close.yml) to include permission settings.
- Ensured that each job within the workflows receives the necessary minimal permissions.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-open.yml | Added top-level and job-level permissions. |
| .github/workflows/pr-close.yml | Introduced explicit permissions for cleanup jobs. |
| .github/workflows/merge.yml | Specified permissions for deployment-related jobs. |
| .github/workflows/csr-generator.yml | Added top-level permissions to the workflow. |
| .github/workflows/.pr-validate.yml | Configured permissions for job-level validation. |
| .github/workflows/.pr-close.yml | Added top-level permissions for consistency. |
mishraomp
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: