fix: aurora v2 #128
Merged
fix: aurora v2 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Aurora v2 Terraform module to pass the subnet group name and adjusts the PR-open workflow dependencies.
- Add
db_subnet_group_nameinput to the Aurora PostgreSQL v2 module - Remove the
plan-stackdependency from the PR-open workflow - (Unintentional) trailing blank line in the Terraform file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infrastructure/database/aurora-v2.tf | Added db_subnet_group_name to the RDS module invocation |
| .github/workflows/pr-open.yml | Removed plan-stack from needs and left environment_name set to prod |
Comments suppressed due to low confidence (3)
.github/workflows/pr-open.yml:72
- Dropping the
plan-stackdependency may allow the deploy job to run before the plan is generated. Consider retainingplan-stackto enforce correct job ordering.
needs: [resume-resources-dev]
.github/workflows/pr-open.yml:75
- The inline comment indicates
environment_nameshould be 'dev', but the code is still set to 'prod'. This mismatch could deploy to the wrong environment.
environment_name: prod # ::change it to:: dev , template repo only has PROD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.