chore: align to serverless for naming and tags #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aligns naming conventions and tag management across the Terraform infrastructure by replacing hardcoded tags with centralized tag variables and ensuring consistency between resource configurations.
- Replaces individual tags blocks with centralized tag variables (var.common_tags or local.common_tags)
- Updates resource naming and comments to include repository information
- Introduces or updates variables for repository name and common tags
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| infrastructure/frontend/waf.tf | Replaces explicit tags with var.common_tags |
| infrastructure/frontend/vars.tf | Adds variables for common tags and repo_name (one variable is duplicated) |
| infrastructure/frontend/cloudfront.tf | Updates S3 bucket names and tag assignments |
| infrastructure/database/vars.tf | Adds repo_name and common_tags variables |
| infrastructure/database/aurora-v2.tf | Replaces hardcoded tags with var.common_tags |
| infrastructure/api/waf.tf | Updates tag usage to local.common_tags; updates comments |
| infrastructure/api/vars.tf | Adds variable for repo_name |
| infrastructure/api/ecs.tf | Adds tag assignments from local.common_tags |
| infrastructure/api/autoscaling.tf | Adds tag assignments from local.common_tags |
| infrastructure/api/api-gateway.tf | Adds tag assignments from local.common_tags |
| .github/workflows/prune-env.yml | Adds a valid prod option for app_env |
| .github/workflows/.stack-prefix.yml | Adjusts repository naming logic for the stack prefix |
| .github/workflows/.deployer.yml | Adds repo_name to the workflow inputs |
infrastructure/frontend/vars.tf
Outdated
Comment on lines
32
to
35
| variable "repo_name" { | ||
| description = "Name of the repository for resource descriptions and tags" | ||
| type = string | ||
| } |
There was a problem hiding this comment.
Duplicate definition of variable 'repo_name' detected. Please remove the redundant declaration to prevent conflicts.
Suggested change
| variable "repo_name" { | |
| description = "Name of the repository for resource descriptions and tags" | |
| type = string | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.