Skip to content

SBCQ160 GA role restricted to csr/ga #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

SBCQ160 GA role restricted to csr/ga #964

merged 2 commits into from
Jul 29, 2024

Conversation

Rajandeep98
Copy link
Collaborator

User story

As a user with the GA role
I want to be prevented from changing another user’s role to support
So that I don’t break something or grant unnecessary privileges to a user.

Acceptance criteria

Users with a GA role can only:

Change the role of a user who has the CSR or GA role.

Change the role of a user from CSR to GA, or vice versa.

Users with a GA role cannot change the role of user who has any other role except CSR.

Copy link
Collaborator

@josekudiyirippil josekudiyirippil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the code. looks like we are adding another condition to check if the user is GA and allowing only GA,CSR edit roles. Will test it out as well

@josekudiyirippil josekudiyirippil self-requested a review July 26, 2024 21:56
Copy link
Collaborator

@josekudiyirippil josekudiyirippil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review tested and loosk good

Copy link

@josekudiyirippil josekudiyirippil merged commit 44fc4bc into bcgov:main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants