Phase 2 BC Developer's Exchange #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated using Authorization Bearer token to a document.cookie value for Websocket connections Switched all authorizations to use Flask-OIDC tokens as opposed to Flask login Add Flask-OIDC and python-jose to requirements.txt Update config setting for development environment to point to openshift environment Remove all references to api URL in development environments
…ators for postman tests
… the API from the same domain as the front-end
…00 level response codes. Use api.marshal instead where it is applicable
Increase logging and ensure that we include an object in socket-io responses, as it appears that flask-socketio will not actually emit the event if the respsonse is empty
Included all tables from CFMS data dictionary. Currently, this webapp uses flask restplus to handle all of its response marshalling. This commit will not make sense until the resources commit happens later. There is a basic bootstrap file that is included with this commit that contains basic database inserts for testing purposes. Future commits to this branch will see resources added for webapp endpoints that work directly with the models created in this commit. Currently the only issues with this commit is the model base class has inheritance issues that need to be investigated. Through testing, it was found that running a migrate of the database without dropping the previous version of the database would cause a cascading error, with the inability to bootstrap new data to cockroach db. To ensure that this webapp can be tested after adding new data to the models, drop the queue_management database, re-create the queue_management database, provide the proper grants to qsystem, and then init, migrate, update, bootstrap and finally runserver for localhost testing.
Resource endpoints currently work with all test data provided in the bootstrap file from the previous commit. All endpoints have been tested to show that the end-points are returning the appropriate data. Known issues include during testing, Firefox is ROUNDING ids that are passed back via get responses. Raw Data shows that the real ids are actually being transmitted, but what is being rendered via browser are not the correct id values. Squash resources
CFMS Phase 2 - Models and Partial Resources
Phase2 - Bug Fixes
…ll as replacing all schema references of "right" to "permissions", as the word right is a reserver postgresql key word. This commit has been tested and verified that all models and resources are now compiling without error. Work TODO: - POST to create citizen - POST to invite citizen - GET single citizen (needs testing) - PUT to update citizen Then resources are complete
Right to Permissions Schema Replace
…nd and found to not be working with current app structure. After code-review, these bug with the initially written code were addressed, and then tested.
…ll as replacing all schema references of "right" to "permissions", as the word right is a reserver postgresql key word. This commit has been tested and verified that all models and resources are now compiling without error. Work TODO: - POST to create citizen - POST to invite citizen - GET single citizen (needs testing) - PUT to update citizen Then resources are complete Squash me - kwargs cleanup for ALL inits Squash me - removed password col on csr model Squash me - Data Dictionary update column names, nullable values Squash me - removed api.model / json return function from all models
…id functions. The get_by_id function call requires that the session is expunged before return so that sessions are not left hanging.
…_by_id functions. The get_by_id function requires that the session by expunged prior to returning anything so that sessions are not left hanging.
…that schemas are now defined in the schema package (next commit). This also means that all models no longer have a json return function as well. All models have had their __repr__ functions ammended to reflect the marshmallow integration as well.
…a validation purposes. Citizens now has a working POST and PUT functions which have been verified through testing with test data. Therefore creating citizens, and updating their data is fully working. Cleaned up all testing print messages, and cleaned up fomatting as well.
…onary requirements.
…flect the integration of marshmallow to the project.
Service Request Get and Put
…tizen to state "Left" is working as intended. Also, have added ST States and Period States data to the manage.py file.
…ti line commented out get function in service_request_list that is no longer needed.
Phase2 Citizen Left + code smells
Added methods for moving the client through its life cycle. Creates all required period objects. Does not yet perform validation to ensure state transitions.
These IDs are liable to change, and must not be hardcoded. Do a select from the database to ensure we get the proper matching ID.
As a client's servicve request move through the workflow, update the state of the corresponding service request so we know where it is in it's lifecycle
…ve default datetime from citizen, and remove hard coded period state id
…were broken down into separate files and then added to a directory inside the resources directory. Qsystem.py was also modified to reflect these changes.
On creation of the service request object, do a count on the number of service requests that match the current service prefix, while the service requests table has been locked, to ensure that duplicates are not created.
Citizen Detail Resource Breakdown.
To invite a generic citizen, the call looks at the quick transaction status of the currently signed in CSR, and tries to find a matching citizen in the queue to invite. If no matching status citizen can be found, then instead we look for any citizen waiting to be queued.
… return a JSON object
Phase2 linting
…which were causing unexpected failures
Removing all smells and issues from sonarqube analysis
Removing all smells and issues from sonarqube analysis
nitheesh-aot
pushed a commit
to nitheesh-aot/queue-management
that referenced
this pull request
Apr 28, 2020
Draft changes for email
gil0109
added a commit
to gil0109/queue-management
that referenced
this pull request
Nov 17, 2020
jhmccoll
pushed a commit
that referenced
this pull request
Nov 19, 2020
convert to ts tables.vue buttons.vue
shabeeb-aot
referenced
this pull request
in shabeeb-aot/queue-management
Mar 28, 2021
Revert ga-screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of API for performing queue-management related tasks.