Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1630 Pagination access control privilege endpoint #1649

Open
wants to merge 7 commits into
base: feat/backend-pagination-sort-search
Choose a base branch
from

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Nov 7, 2024

  • Adjust endpoint "/access_control_privileges" to "/access-control-privileges"
  • Add pagination schema objects for pagination related classes used by endpoint.
  • Add "page_params" query parameter for "/access-control-privileges?application_id" for pagination capability.
  • Use "create_date" as default sorting.
  • Add simple paginate abstract repository to provide pagination functionality for server/admin_management.
  • Implement paginate repository in access_control_privilege_repository for getting delegated admins.
  • access_control_privilege_service uses and return paged delegated admins from repository paged method.
  • Client-Code gen for frontend admin_management api.
  • Adjust frontend due to endpoint change.
  • Fix affected tests.

Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review November 7, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant