Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FSADT1-848): fixing external form style #568

Merged
merged 355 commits into from
Oct 23, 2023
Merged

fix(FSADT1-848): fixing external form style #568

merged 355 commits into from
Oct 23, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Aug 23, 2023 •
edited
Loading

Description

This is the second round of fixes for the external form.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • New unit tests
  • New component tests
  • New end-to-end tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added javascript Pull requests that update Javascript code source source code changes configuration changes related to configuration file frontend fix labels Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023 •
edited
Loading

Current changelog

Bug Fixes

Features

  • add callback argument to useFocus (a515481)
  • add formErrors variable (9344a5d)
  • add parameter for the shadow directive (2e8a899)
  • add tooltip to button Next (ae3a94d)
  • adjust header buttons (10fbe85)
  • adjust header logo and buttons (94651ce)
  • adjust header spaces and breakpoints (88277ef)
  • adjust margins (c6747a7)
  • allow some time before showing the loading icon (0266963)
  • clear text displayed on combo-box (9636608)
  • display address extra errors (48c1646)
  • display progress indicator vertically (83dcfec)
  • dropdown updated (6855af2)
  • make the bindings to create and scroll to new contact (ee84729)
  • move extra errors to the error component (6754aad)
  • replace formErrors argument with notification approach (37c8480)
  • replace margin with padding (42896f4)
  • scroll to new contact (5a022fb)
  • show help modal (6d3b6e6)
  • show loading icon on auto-complete fields (68020b3)
  • show logout modal (db23ce1)
  • turn the dollar signal required (24707fe)
  • updating autocomplete (874ab7e)
  • updating carbon web components (03bec35)
  • updating global error notification (846e398)
  • updating modal and toast (0c2d32f)
  • updating multi select (46d7557)
  • updating progress indicator (8a0d271)
  • updating styles (408166a)
  • updating test input (78521be)
  • use media query instead of outerWidth to determine screen size (7c80197)
  • use variable to tell if selection was a user event (ed22a30)

Reverts

  • Revert "Removed class that was causing issues with the logout button" (eab2a43)
  • Revert "Changed hover color for tertiary buttons" (e6854e8)

@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code fix and removed fix labels Aug 23, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev August 23, 2023 13:58 — with GitHub Actions Inactive
@github-actions github-actions bot added java Pull requests that update Java code backend code related to the java backend application fix and removed fix labels Aug 23, 2023
@github-actions github-actions bot added fix and removed fix labels Aug 23, 2023
@github-actions github-actions bot added fix and removed fix labels Aug 23, 2023
@github-actions github-actions bot added fix and removed fix labels Aug 23, 2023
@github-actions github-actions bot added tests test classes changes fix and removed fix labels Aug 23, 2023
@mamartinezmejia mamartinezmejia temporarily deployed to dev October 20, 2023 23:06 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev October 20, 2023 23:11 — with GitHub Actions Inactive
@github-actions github-actions bot added fix and removed fix labels Oct 20, 2023
@github-actions github-actions bot added fix and removed fix labels Oct 23, 2023
@github-actions github-actions bot added fix and removed fix labels Oct 23, 2023
@github-actions github-actions bot added fix and removed fix labels Oct 23, 2023
@sonarqubecloud
Copy link

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[forest-client-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

60.5% 60.5% Coverage
1.1% 1.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mamartinezmejia mamartinezmejia temporarily deployed to dev October 23, 2023 15:28 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev October 23, 2023 15:33 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj merged commit 15b7ae2 into main Oct 23, 2023
@paulushcgcj paulushcgcj deleted the feat/be/external-form-fixes branch October 23, 2023 15:35
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
1 task
paulushcgcj added a commit that referenced this pull request Oct 23, 2023
@paulushcgcj @fterra-encora @mamartinezmejia
fix(FSADT1-848): fixing external form style (#568)
09952b3 
* fix: fixing progress state when error

* fix: fixing error notification

Fixing error notification below progress indication.

* fix: fixing dropdown

* fix: fixing multi select

* chore: updating stubs to add more addresses

* fix: fixing dropdown not changing when selection change

* feat: add formErrors variable

* chore: redoing css changes - Part #1

* feat: display address extra errors

* feat: move extra errors to the error component

* chore: redoing css changes - Part #2

* feat: replace formErrors argument with notification approach

* feat: scroll to new contact

* feat: add callback argument to useFocus

* feat: make the bindings to create and scroll to new contact

* chore: minor adjusments on useFocus

* chore: redoing css changes - Part #3

* chore: redoing css changes - Part #4

* test: test the validation function and the error component

* fix: update contactType value on select

* test: ignore already valid location

* test: remove outdated test

* feat: add parameter for the shadow directive

* feat: display progress indicator vertically

Also adds some changes for displaying it horizontally.

* FSADT1-868: Allowed special characters. Done olnly in the Frontend as the Backend was already allowing special charactes.

* test: add getMany command

* test: add progress indicator tests

* fixed inline notification colors

* Removed wrong style

* Added property needed

* feat: show logout modal

* refactor: unify code for the logout button in different sizes

* feat: show help modal

* feat: use media query instead of outerWidth to determine screen size

* Removed class that was causing issues with the logout button

* Revert "Removed class that was causing issues with the logout button"

This reverts commit 827e496.

* Fixed logout button

* feat: adjust header buttons

* Fixed mask issue with the postal code

* Renamed some files before refactoring code

* no message

* Made code reviews

* chore: remove console.log

* fix: prevent an older request from overwriting the results

* Made requiered changes

* Removed repeatead code

* Removed unneeded setting

* fix: do not always block response from older request

It should be allowed when no newer request was yet responded.

* chore: use simple counter to generate requestId

* fix: init fetching

* test: fix test

* Fixed file

* Added javadoc comment as per requested by SonarCloud

* docs: improve comment

* feat: adjust header logo and buttons

* feat: adjust header spaces and breakpoints

* chore: use date milliseconds as id

* fix: fix build issue

* fix: prevent error in the workflow

* fix: attempt to fix tests in the workflow

* fix: remove package from optimizeDeps

As an attempt to prevent error in the workflow.

* refactor: requested changes from review

* Refactored code - Part #1

* Made code reviews

* Formatted and beautified code

* style: small changes to code style

* chore: fix code linter

* Refactored code - Part #1.1

* fix: Fixed sonarcloud security hotspot issue

* fix: Fixed security hotspot

* Refactored code - Part #2

* Refactored code - Part #2.1

* fix: fix header small screen

* fix: attempt to fix side effect in the workflow

* chore: submitting small changes

* fix(FSADT1-884): fixing steps being enable

- adjusted the steps to be disable by default
- only enable if valid and only for the next step

* chore: sorting import

* fix(FSADT1-887): fixing typo on step 4

* fix(FSADT1-889): fixing font style

* fix: Fixed security hotspot and improved wording

* fix: Fixed security hotspot

* fix(FSADT1-888): fixing spacing between radio buttons

* Trying a different approach to solve the security hotspot issue

* fix(FSADT1-892): fixing submission page

* Trying a different approach to solve the security hotspot issue #2

* fix(FSADT1-894): fixing field spacing and width

* fix(FSADT1-891): fixing modal spacing

* fix(FSADT1-889): fixing notification body content

* fix(FSADT1-890): fixing component alignment

* fix: Fixed security hotspot

* fix: Fixed security hotspot

* Made code reviews

* Removed unused variable

* Refactored code and made code reviews

* feat: adjust margins

* fix(FSADT1-884): removing navigation link

* Made code reviews

* fix: header height

* chore: replace mock e-mail from .local to .com

* fix: do not pre-validate current step

* feat: replace margin with padding

* FSADT1-899: Removed unneeded validation

* ci: updating trivy to fix issues

* no message

* no message

* Tried to skip SonarCloud validation

* Skipped SonarCloud validation

* chore: adding us address stub data

* fix(FSADT1-884): fixing subtitle style

* fix: autocomplete after changing country

* fix: fix subtitle style for vertical progress indicator

* fis(FSADT1-894): fixing style for inline and text

* Made code reviews

* FSADT1-879

* - Made code reviews
- Removed unused code

* Made code reviews

* Made code reviews

* Made improvement

* feat: clear text displayed on combo-box

* fix: clear text displayed on combo-box

Without using any private properties from the component.

* refactor: move iteration props

* fix: fix link to bceid

* chore: remove unused import

* fix: remove placeholders on country and province

* fix: fix casing for Business information

* fix: fix doc coment closing

For some reason this was messing the code displayed in the Chrome browser
sources.

* fix: conditions used on postalCode validations

* chore: fix VS Code resolution for source and test files

By fixing the test configuration and eliminating a conflict with the app
one.

* test: use a new query command after a click

Since it's unsafe to chain after a click.

* test: force click button

* fix: prevent completing business step with invalid data

* fix: prevent fetching for name "undefined"

* test: wait before clicking the option

* Made a minor change for internal emails after a conversation with Andrew.

* style: add semi-colon as requested after review

* style: add the dollar signal to all conditions

* feat: turn the dollar signal required

* Made code reviews

* Made more code reviews

* Made this to prevent perisisting information mutliple times

* test: wait for the option's inner element to become visible

* fix: emit error always for text-input

Instead of only when the error changes.

* fix: update error status on Address step text fields

So to be able to properly make it valid later when it gets resolved.

* fix: update Street address empty status properly

* test: emit empty true when contents is empty

* docs: refer specific Jira issue

* fix:
- Renamed variable and added an new property to make it more generic
- Beautified code

* fix:
- Renamed variable and added an new property in test file

* fix: Made code reviews and removed unneeded prop I added

* fix: update error status on Contacts step text fields

So to be able to properly make it valid later when it gets resolved.

* test: emit valid events properly

* no message

* fix:
- Renamed variable with a proper name
- Made code reviews

* docs: improve comment

* docs: improve comment

* fix: synchronize dropdown value

* fix: get country validation

* fix: validate after changed from outside

* test: define some tests to be implemented

* test: province gets cleared

* docs: add issue references

* test: revalidates when changed from outside

Also fixes another test.

* Fast commit to switch branches

* fix: validate the item code instead of its name

* test: update tests

* fix: remove meaningless tag

* fix: do not display field as invalid

When the field is empty and user didn't have a chance to add its value yet.
For example, when it gets auto-changed as a result of changing another field.

* Fast commit to switch branches

* fix: Made code reviews and added birth date field

* fix: Fixed logo for small screens

* test: do not emit error in specific situation

* feat: use variable to tell if selection was a user event

* test: update tests

* chore: use variable to tell if the change was a user event

* test: update test

* feat: add tooltip to button Next

* fix: proceed applying part to next level

Regardless of current element already having a part attribute.

* chore: adjust combo-boxes focus outline

* Fast commit to switch branches

* Modified gitignore

* feat:
- Removed unused code
- Made code reviews

* feat:
- Made more code reviews

* Fast commit to switch branches

* Renamed class with a more generic name

* Fast commit to switch branches

* Made more code reviews

* Fast commit to switch branches

* Pushed common functions

* Fast commit to switch branches

* fix: fix AutoComplete events

- fix empty value;
- always emit the error;
- do not validate at each key pressed.

* test: add empty and error tests

* fix: fix initial empty value

* removed unneeded key

* fix: allow selecting item identical to the typed value

* test: update test

* Fast commit to switch branches

* test: add address group test

* Fast commit to switch branches

* test: fix import

* feat: show loading icon on auto-complete fields

* feat: allow some time before showing the loading icon

* chore: add helper text

* fix: validate multi-select field

* fix: remove deleted address from contacts

* Fast commit to switch branches

* chore: small fix to remove extra spaces on the first step

* - Made code reviews
- Improve code and made it more genetic

* Made code reviews

* FSADT1-928

* Fixed code smell issues

* Fixed code smell issues

* Create unit test

* chore: forcing update

* Changed annotation

* Renamed file as it had a typo

* chore: apply custom directives to unit tests

* Fixed some smell issues

* test: attempt to fix test on github actions

* Made more code reviews

* Made more code reviews

* chore: adjust Application submitted breakpoints

* chore: adjust margins on Application submitted

* fix: adjust header buttons breakpoint

Import missing variable.

* Added more coverage

* Beautified CSS file

---------

Co-authored-by: Fernando Terra <fernando.terra@encora.com>
Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca>
Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

Assignees
No one assigned
Labels
backend code related to the java backend application configuration changes related to configuration file fix frontend github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code javascript Pull requests that update Javascript code source source code changes tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulushcgcj @mamartinezmejia @fterra-encora