-
Notifications
You must be signed in to change notification settings - Fork 5
OHID-330 Angular 19 #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paahn
wants to merge
55
commits into
develop
Choose a base branch
from
feature/OHID-330-angular-19
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OHID-330 Angular 19 #689
+4,187
−4,193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/OHID-330-angular-19
…o feature/OHID-330-angular-19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready For Review
PR is code-complete (or very close) and only needs some review and/or manual testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routerTestingModule
is deprecated, replace withRouterModule.forRoot([])
"moduleResolution": "bundler"
andesModuleInterop= true
to combat Keycloak js removing support for The UMD distribution Universal Module Definition of the Keycloak JS library. This means that the library is no longer exposed as a global variable, and instead must be imported as a module. esModuleInteropKeycloakService
toKeycloak
from thekeycloak-js
library. Re-implement how we initialize keycloak in the applicationkeycloak-angular
to v19 but keptkeycloak-js
at v25 due to an issue with test files not able to resolve thekeycloak-js
26 and higher versions. See herekeycloak-angular
v19 following the official library guide