[MDS-6681] MineSpace User Access Login flow #3803

taraepp · 2026-01-21T19:44:05Z

Objective

new landing page
new behaviour:
- basically we are saving their access request form data in our database
- handling keycloak calls ourselves
- giving MS users roles within mines

taraepp · 2026-01-21T19:54:02Z

services/common/src/components/forms/RenderMultiSelect.tsx

                id={props.id ?? props.input.name}
                onSearch={debouncedSearch}
                options={data}
+                value={input.value === "" ? [] : input.value}


I had weird issues with the mines not being pre-populated from the form values and had to make this change. In making this change, I had to manually apply the aria-required (a bunch of snapshot tests showed it being removed. Now it added in a few aria-required=false but I'm okay with that)

taraepp · 2026-01-21T19:56:38Z

services/core-api/app/api/services/css_sso_service.py

+        return user_emails
+
+    @staticmethod
+    def get_roles_by_user(username: str):


New functions can be used to handle any keycloak role management! If we wanted to give CORE users roles from within the app...

taraepp · 2026-01-21T20:07:01Z

services/minespace-web/src/HOC/AuthenticationGuard.tsx

+ * CORE/IDIR users are authenticated programmatically when MineSpace mounts,
+ */
+
+export const AuthenticationGuard =


This file was really just typescripted. No effort made to improve it otherwise (probably wouldn't use window.location)

taraepp · 2026-01-21T20:09:08Z

services/minespace-web/src/components/pages/LandingPage.tsx

 import * as Strings from "@mds/common/constants/strings";
-import PropTypes from "prop-types";
-// Uncomment when image is re-introduced
-// import { MAP_LOGO } from "@/constants/assets";


There was a lot of stuff in this file that was basically half-implemented, in testing only functionality that was either commented out, or only available on test.
I removed all of that. If we want to implement logging in with verifiable credentials or whatever was going on with the commented out stuff, we'll do that properly.

sonarqubecloud · 2026-01-21T20:18:05Z

Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
71.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud · 2026-01-21T20:18:40Z

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
31.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-01-21T20:22:26Z

Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
64.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-01-21T20:24:31Z

Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
74.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copilot

Pull request overview

This PR implements a new self-service user access request flow for MineSpace, where BCeID users can submit access requests through a comprehensive form. The system saves access request data to the database and manages Keycloak role assignments. Key features include:

Changes:

New landing page with updated design and "Join MineSpace" functionality
Self-service access request form for new MineSpace users with authorization workflow
Backend API endpoints for managing user access requests and document uploads
Feature flag controlled rollout (MINESPACE_SIGNUP)

Reviewed changes

Copilot reviewed 90 out of 91 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
services/minespace-web/src/components/pages/MinespaceAccessRequest.tsx	New access request form component with Terms of Use and Privacy Notice
services/minespace-web/src/components/pages/LandingPage.tsx	Redesigned landing page with feature flag support for new signup flow
services/minespace-web/src/HOC/AuthenticationGuard.tsx	Updated authentication logic to store user access data from Keycloak
services/document-manager/backend/app/docman/resources/document.py	Added authorization bypass for minespace access request document uploads
services/core-web/src/components/admin/MinespaceUserAccessModal.tsx	Admin interface for reviewing and approving access requests
services/core-api/tests/users/resources/test_new_minespace_user_resource.py	Comprehensive test coverage for new API endpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T22:26:10Z

services/minespace-web/src/components/pages/MinespaceAccessRequest.tsx

+          <Typography.Paragraph>Typical processing time: 5-10 business days</Typography.Paragraph>
+          <Typography.Paragraph strong>What you'll need:</Typography.Paragraph>
+          <ul>
+            <li>Your role and associated business name (as registered with Business BCeiD)</li>


Spelling error: "BCeiD" should be "BCeID" (lowercase 'e') to match the official branding and other instances in the codebase.

Copilot · 2026-01-21T22:26:11Z

services/minespace-web/src/HOC/AuthenticationGuard.tsx

+        const clientRoles = token?.client_roles || [];
+
+        if (keycloak.authenticated && !authenticationInProgressFlag && !type) {
+          localStorage.setItem("authenticationInProgressFlag", "true");


The localStorage flag is being set to the string "true" but checked as a truthy value. Consider using boolean true instead, or ensure the check elsewhere handles string "true" properly. Inconsistent types can lead to bugs.

Copilot · 2026-01-21T22:26:11Z

services/core-api/tests/users/models/test_minespace_user.py

+
+    assert user is not None
+    assert user.bceid_username == bceid_username
+    assert user.deleted_ind == None


Testing for None should use the 'is' operator.

Copilot · 2026-01-21T22:26:11Z

services/core-api/app/api/users/minespace/resources/minespace_user.py

            current_app.logger.info('Existing Mine: {}'.format(existing_minespace_user_mine))
            if not existing_minespace_user_mine:
-                new_minespace_user_mine = MinespaceUserMine.create(user_id, mine.mine_guid)       
+                new_minespace_user_mine = MinespaceUserMine.create(user_id, mine.mine_guid)


Variable new_minespace_user_mine is not used.

Suggested change

new_minespace_user_mine = MinespaceUserMine.create(user_id, mine.mine_guid)

MinespaceUserMine.create(user_id, mine.mine_guid)

Copilot · 2026-01-21T22:26:12Z

services/core-api/tests/users/models/test_minespace_user_request.py

+    mine2 = MineFactory()
+
+    # complete permittee form submission with mines
+    request = MinespaceUserRequest.create_or_update_request(


Variable request is not used.

Copilot · 2026-01-21T22:26:13Z

services/core-api/app/api/users/minespace/resources/new_minespace_user.py

+from app.api.users.minespace.models.minespace_user_request import MinespaceUserRequest
+# Import these models to ensure they're registered with SQLAlchemy (avoid circular import issues)
+from app.api.users.minespace.models.minespace_user_role_xref import MinespaceUserRoleXref
+from app.api.users.minespace.models.minespace_user_roles import MinespaceUserRole


Import of 'MinespaceUserRole' is not used.

Copilot · 2026-01-21T22:26:13Z

services/core-api/tests/users/models/test_minespace_user_request.py

@@ -0,0 +1,164 @@
+from datetime import datetime


Import of 'datetime' is not used.

Copilot · 2026-01-21T22:26:14Z

services/core-api/tests/users/models/test_minespace_user_request.py

@@ -0,0 +1,164 @@
+from datetime import datetime
+from pytz import utc


Import of 'utc' is not used.

Copilot · 2026-01-21T22:26:14Z

services/core-api/app/api/users/minespace/models/minespace_user_document_xref.py

+from app.api.utils.models_mixins import SoftDeleteMixin, Base
+
+
+class MinespaceUserDocumentXref(SoftDeleteMixin, Base):


Base classes have conflicting values for attribute 'delete': Function delete and Function delete.

Copilot · 2026-01-21T22:26:14Z

services/core-api/app/api/users/minespace/models/minespace_user_role_xref.py

+from app.api.utils.models_mixins import SoftDeleteMixin, AuditMixin, Base
+
+
+class MinespaceUserRoleXref(SoftDeleteMixin, AuditMixin, Base):


Base classes have conflicting values for attribute 'delete': Function delete and Function delete.

taraepp added 4 commits December 16, 2025 19:05

database migration

4545eed

use new signup flow

e812375

snapshot tests

5bb28e2

upstream changes

b6c2682

taraepp commented Jan 21, 2026

View reviewed changes

add to test_expected_auth, and also tidy up a response model

a4a75d6

simensma-fresh requested a review from Copilot January 21, 2026 22:18

Copilot started reviewing on behalf of simensma-fresh January 21, 2026 22:19 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

	new_minespace_user_mine = MinespaceUserMine.create(user_id, mine.mine_guid)
	MinespaceUserMine.create(user_id, mine.mine_guid)

		@@ -0,0 +1,164 @@
		from datetime import datetime
		from pytz import utc

		from app.api.utils.models_mixins import SoftDeleteMixin, Base


		class MinespaceUserDocumentXref(SoftDeleteMixin, Base):

		from app.api.utils.models_mixins import SoftDeleteMixin, AuditMixin, Base


		class MinespaceUserRoleXref(SoftDeleteMixin, AuditMixin, Base):

[MDS-6681] MineSpace User Access Login flow #3803

Are you sure you want to change the base?

[MDS-6681] MineSpace User Access Login flow #3803

Conversation

taraepp commented Jan 21, 2026

Objective

Uh oh!

taraepp Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

taraepp Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

taraepp Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

taraepp Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants